Any clue why AndroidBufferImageLoader is deprecated?

Ali_RS · November 6, 2021, 8:21pm

Hi

Does anybody know why AndroidBufferImageLoader is deprecated?

jMonkeyEngine/jmonkeyengine/blob/2542ceb565ce6e4cf561cf6c61b4d2028d8f52b8/jme3-android/src/main/java/com/jme3/texture/plugins/AndroidBufferImageLoader.java#L54

    
      
          import java.io.InputStream;
          import java.nio.ByteBuffer;
          
          
/**
           * Loads textures using Android's Bitmap class, but does not have the 
           * RGBA8 alpha bug.
           * 
           * @author Kirill Vainer
           */
          @Deprecated
          public class AndroidBufferImageLoader implements AssetLoader {
              
              private final byte[] tempData = new byte[16 * 1024];
              
              private static void convertARGBtoABGR(int[] src, int srcOff, int[] dst, int dstOff, int length) {
                  for (int i = 0; i < length; i++) {
                      int argb = src[srcOff + i];
                      int a = (argb & 0xFF000000);
                      int b = (argb & 0x000000FF) << 16;
                      int g = (argb & 0x0000FF00);
                      int r = (argb & 0x00FF0000) >> 16;

Should we undeprecate it?

richtea · November 6, 2021, 8:44pm

The commit that deprecated it is Android Images: deprecate classes that won't be used in 3.1 · jMonkeyEngine/jmonkeyengine@bbbcd8e · GitHub

Just says “Android Images: deprecate classes that won’t be used in 3.1”. Not sure if that’s that conclusive

Pavl_G · November 6, 2021, 10:35pm

Seems to be the reason why :

github.com

jMonkeyEngine/jmonkeyengine/blob/2542ceb565ce6e4cf561cf6c61b4d2028d8f52b8/jme3-android/src/main/java/com/jme3/texture/plugins/AndroidNativeImageLoader.java#L12

    
      
          

          import com.jme3.asset.AssetInfo;

          import com.jme3.asset.AssetLoader;

          import com.jme3.asset.TextureKey;

          import com.jme3.texture.Image;

          import java.io.IOException;

          import java.io.InputStream;

          

          /**

           * Native image loader to deal with filetypes that support alpha channels.

           * The Android Bitmap class premultiplies the channels by the alpha when

           * loading.  This loader does not.

           *

           * @author iwgeric

           * @author Kirill Vainer

           */

          public class AndroidNativeImageLoader  implements AssetLoader {

              

              private final byte[] tmpArray = new byte[10 * 1024];

              

              static {

pspeed · November 6, 2021, 10:35pm

It’s not, unfortunately. Nothing we’ve found says why it won’t be used in 3.1… and we’re even assuming a bit that “3.1” refers to JME 3.1. I mean, it probably does but who really knows?

Perhaps kirill remembers but we’ve been unable to summon his apparition. I don’t know if the @Momoko_Fan tag will still work.

sgold · November 22, 2021, 6:08am

It will be un-deprecated in v3.5: