Bug in the 'RenderState' class

capdevon · December 24, 2021, 12:46pm

Hi everyone,
wrong name when saving the backStencilStencilFailOperation parameter in the RenderState.write(JmeExporter ex) method.

github.com

jMonkeyEngine/jmonkeyengine/blob/master/jme3-core/src/main/java/com/jme3/material/RenderState.java#L506

    
      
          oc.write(depthTest, "depthTest", true);

          oc.write(colorWrite, "colorWrite", true);

          oc.write(blendMode, "blendMode", BlendMode.Off);

          oc.write(offsetEnabled, "offsetEnabled", false);

          oc.write(offsetFactor, "offsetFactor", 0);

          oc.write(offsetUnits, "offsetUnits", 0);

          oc.write(stencilTest, "stencilTest", false);

          oc.write(frontStencilStencilFailOperation, "frontStencilStencilFailOperation", StencilOperation.Keep);

          oc.write(frontStencilDepthFailOperation, "frontStencilDepthFailOperation", StencilOperation.Keep);

          oc.write(frontStencilDepthPassOperation, "frontStencilDepthPassOperation", StencilOperation.Keep);

          oc.write(backStencilStencilFailOperation, "frontStencilStencilFailOperation", StencilOperation.Keep);

          oc.write(backStencilDepthFailOperation, "backStencilDepthFailOperation", StencilOperation.Keep);

          oc.write(backStencilDepthPassOperation, "backStencilDepthPassOperation", StencilOperation.Keep);

          oc.write(frontStencilFunction, "frontStencilFunction", TestFunction.Always);

          oc.write(backStencilFunction, "backStencilFunction", TestFunction.Always);

          oc.write(blendEquation, "blendEquation", BlendEquation.Add);

          oc.write(blendEquationAlpha, "blendEquationAlpha", BlendEquationAlpha.InheritColor);

          oc.write(depthFunc, "depthFunc", TestFunction.LessOrEqual);

          oc.write(lineWidth, "lineWidth", 1);

          oc.write(sfactorRGB, "sfactorRGB", sfactorRGB);

          oc.write(dfactorRGB, "dfactorRGB", dfactorRGB);

Ali_RS · December 24, 2021, 2:09pm

Hi

Good catch! Any chance for a PR?

Thanks

capdevon · December 24, 2021, 4:15pm

Hi Ali,
meanwhile, I open an issue to track the bug. I don’t have my personal computer right now. To speed things up, I leave the PR to you or to @sgold if it’s not a problem.

github.com/jMonkeyEngine/jmonkeyengine

Wrong name value in the RenderState.write(JmeExporter ex) method.

opened 04:11PM - 24 Dec 21 UTC

capdevon

I opened this issue to keep track of the forum discussion https://hub.jmonkeyen…gine.org/t/bug-in-the-renderstate-class/45214 Wrong name value when saving the `backStencilStencilFailOperation` parameter in the `RenderState.write(JmeExporter ex)` method. https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-core/src/main/java/com/jme3/material/RenderState.java#L506 ```java @Override public void write(JmeExporter ex) throws IOException { OutputCapsule oc = ex.getCapsule(this); ... oc.write(backStencilStencilFailOperation, "frontStencilStencilFailOperation", StencilOperation.Keep) ```

Ali_RS · December 24, 2021, 4:27pm

Thanks for opening the issue. I will submit a patch soon.

Ali_RS · December 24, 2021, 5:15pm

Submitted a fix at