[committed] Removing compulsive interpolation in BoneAnimation

archive contribution-depot-jme2
1

When we read BoneAnimation from Savable interface,

it is always set to true.

I guess it is test code and not removed.



Index: src/com/jme/animation/BoneAnimation.java
===================================================================
--- src/com/jme/animation/BoneAnimation.java   (revision 4048)
+++ src/com/jme/animation/BoneAnimation.java   (working copy)
@@ -1012,9 +1012,6 @@
             }
         }
 
-        //TODO: hack to enable interpolation - rherlitz
-        interpolationRate = 0.0f;
-        interpolate = true;
         // Update the method Javadoc when non-interpolation is supported again.
         interpolationType = new int[keyframeTime.length];
         for (int i = 0; i < keyframeTime.length; i++) {

2

There is already a method BoneAnimation.setInterpolate().

And the variable 'interpolate' is already loaded/saved by read()/write().

3

instead of just removing it, shouldn't there be a way to enable / disable it?

4

Since there are getter and setters, i also don't see a reason for the hack.

I never used this animation stuff tho.

5

Everybody agrees on this?  :?

Then I'll check it in.  :slight_smile: