Disabling focus color in Lemur

louhy · March 19, 2017, 6:54pm

Is there any simple global way to disable the green text color when a button is focused?

Really, I wouldn’t mind disabling focus features (navigation and visuals) completely, but then text input fields and such which need focus won’t work. I guess I could subclass Button and try disabling focus or focus color in the constructor - any other ways that require fewer code changes before I start looking into that?

pspeed · March 19, 2017, 9:15pm

Is it the color you don’t like or you just don’t want to be able to use keyboard navigation at all?

Edit: because focusColor is a stylable property so you could set it globally just by setting the style.

louhy · March 20, 2017, 11:45pm

It’s not that specific color, I’d rather not have it change color at all. I could try making the focus color the same as the text default, but not sure if it’ll prevent me from overriding the color when I want to show the button “toggled” on.

pspeed · March 21, 2017, 1:07am

Just set it to null for the style and it disables it.

louhy · March 21, 2017, 1:24am

Almost - that did stop the green, but now it stays yellow (the mouseover color) after being clicked. Can’t disable that one, we gotta have mouseover indicators.

pspeed · March 21, 2017, 1:57am

Mm… seems like maybe the resetColors() method needs a slight refactoring…

github.com

jMonkeyEngine-Contributions/Lemur/blob/master/src/main/java/com/simsilica/lemur/Button.java#L288


public boolean isPressed() {
    return pressed;
}
public boolean isHighlightOn() {
    return highlightOn;
}
public boolean isFocusHighlightOn() {
    return focusOn;
}
public boolean isFocused() {
    return getControl(GuiControl.class).isFocused();
}
protected void showHighlight( boolean f ) {
    highlightOn = f;
    resetColors();
}

To avoid taking the branches if the colors are null… since it’s a big if/else chain.

louhy · March 21, 2017, 5:58pm

Not precisely sure what you have in mind, maybe this introduces other issues, but this does seem to work for me (with focusColor=null) without breaking focus when focusColor is null.

protected void resetColors() {
    boolean colorNotSet = true;
    boolean shadowColorNotSet = true;
    if (focusOn && highlightOn) {
        // Mix them
        ColorRGBA color = mix(getHighlightColor(), getFocusColor());
        if (color != null) {
            super.setColor(color);
            colorNotSet = false;
        }
        ColorRGBA shadow = mix(getHighlightShadowColor(), getFocusShadowColor());
        if (shadow != null) {
            super.setShadowColor(shadow);
            shadowColorNotSet = false;
        }
    } else if (highlightOn) {
        if (getHighlightColor() != null) {
            super.setColor(getHighlightColor());
            colorNotSet = false;
        }
        if (getHighlightShadowColor() != null) {
            super.setShadowColor(getHighlightShadowColor());
            shadowColorNotSet = false;
        }
    } else if (focusOn) {
        if (getFocusColor() != null) {
            super.setColor(getFocusColor());
            colorNotSet = false;
        }
        if (getFocusShadowColor() != null) {
            super.setShadowColor(getFocusShadowColor());
            shadowColorNotSet = false;
        }
    }
    if (colorNotSet) {
        // Just the plain color
        super.setColor(getColor());
    }
    if (shadowColorNotSet) {
        super.setShadowColor(getShadowColor());
    }
}

pspeed · March 21, 2017, 6:05pm

It’s not exactly what I had in mind but the effect is the same. The only down side is that it allows shadow colors to mix with colors not necessarily intended.

But if it’s working for you then it’s good until I do a fix (soon I hope).

Edit: if you are curious… my fix would have been to change the conditions to include null checks for the main color… but actually I run into a similar shadow color issue that way.