Dome center null check

d0c · January 14, 2009, 9:26am

com.jme.scene.shape.Dome.updateGeometry(Vector3f center, int planes, int radialSamples, float radius, boolean outsideView) gives this.center a default value in case center is null, but this default value is not set to local variable center itself thus causing NullpointerException

basixs · January 14, 2009, 10:58am

Write a patch, or post some code; if your right it will probably go in right away

…And welcome to the forums.

d0c · January 14, 2009, 12:02pm

> Write a patch

Attached

> And welcome to the forums

Thx

Core_Dump · January 14, 2009, 12:43pm

good catch, only this.center should have been used in updateGeometry()

basixs · January 14, 2009, 5:47pm

Does anyone else see a link or patch?

(cause I don't…)

d0c · January 15, 2009, 6:55am

> Does anyone else see a link or patch?

File name is Dome.java.diff.txt and should be seen on the bottom of my post. Others have downloaded it, so problem must be your board settings or browser.

Direct link:

http://www.jmonkeyengine.com/jmeforum/index.php?action=dlattach;topic=10196.0;attach=156

basixs · January 16, 2009, 7:54am

Sweet, global moderator status and I am locked out from downloading or viewing attachments

(clicking on your linked confirmed that)

(I guess that means I am moderated globally? :D)

too bad I cant change my own settings