Why have you introduced this getType()? I liked instanceof alot more - it's Java!
If it is because of the myth that instanceof would be slow, one can easily proove the opposite:
Run this simple test with JRE1.5:
package jmetest.util;
import java.util.logging.Level;
import com.jme.app.SimpleGame;
import com.jme.scene.Geometry;
import com.jme.scene.Node;
import com.jme.scene.Spatial;
import com.jme.scene.shape.Box;
import com.jme.util.LoggingSystem;
/**
*
*/
public class TestInstanceOf extends SimpleGame {
private static final int COUNT = 100000;
/**
* Called near end of initGame(). Must be defined by derived classes.
*/
protected void simpleInitGame() {
Spatial[] spatial = new Spatial[COUNT];
for ( int i = 0; i < COUNT; i++ ) {
if ( ( i & 1 ) != 0 ) {
spatial[i] = new Node( null );
}
else {
spatial[i] = new Box( null );
}
}
{
long start = System.currentTimeMillis();
for ( int j = 0; j < 100; j++ ) {
for ( int i = 0; i < COUNT; i++ ) {
Spatial s = spatial[i];
if ( s instanceof Node ) {
( (Node) s ).getQuantity();
}
else if ( s instanceof Geometry ) {
( (Geometry) s ).getModelBound();
}
}
}
long time = System.currentTimeMillis() - start;
System.out.println( "With instanceof: " + time + " ms" );
}
{
long start = System.currentTimeMillis();
for ( int j = 0; j < 100; j++ ) {
for ( int i = 0; i < COUNT; i++ ) {
Spatial s = spatial[i];
if ( ( s.getType() & Spatial.NODE ) != 0 ) {
( (Node) s ).getQuantity();
}
else if ( ( s.getType() & Spatial.GEOMETRY ) != 0 ) {
( (Geometry) s ).getModelBound();
}
}
}
long time = System.currentTimeMillis() - start;
System.out.println( "Without instanceof: " + time + " ms" );
}
System.exit( 0 );
}
public static void main( String[] args ) {
LoggingSystem.getLogger().setLevel( Level.WARNING );
new TestInstanceOf().start();
}
}
Output:
With instanceof: 1632 ms
Without instanceof: 2063 ms
So why getType :?
so, if this is the case, we can change the getType stuff in the jME core back to instanceof and no one will know. We can leave the getType for other people to use if they wish. I guess we need something more authoritative than a couple articles on the web and a micro-benchmark.