I'm confused by the comments of UniformBinding.java

Development
1

I’m confused by the comments of LightPosition and LightDirection.

com/jme3/shader/UniformBinding.java

/**
 * The light position when rendering in multi pass mode
 * Type: vec4
 */
LightDirection("vec4"),

/**
 * The light direction when rendering in multi pass mode
 * Type: vec4
 */
LightPosition("vec4"),

I think it’s a mistake because in MultiPassLightingLogic.java I see how those uniforms are setup.

I want to confirm if it’s a typo, then I will make a PR to fix it.

@nehon

1 Like
2

Looks like a typo yes.

3

This is my PR.

1 Like