jMonkeyEngine v3.7 feature freeze

fba · April 27, 2024, 6:09pm

Thanks for your reply @adi.barda . Let me know if I can help someway.

adi.barda · April 28, 2024, 11:08am

Hi Guys,
I have assembled a small simple test app reproducing material issue I found with a specific GLTF model. It happens only with JME 3.7.0. with version 3.6.1 stable it works fine so we have some kind of regression in 3.7.0.

Here is how it looks in 3.6.1

And here using 3.7.0-alpha3.1

Below is a link to the test app. Hopefully someone in our community will manage to find the issue with this model…

Thanks a lot

sgold · May 2, 2024, 5:29am

I’d hate to see a single issue hold up the release.

Is anyone besides Adi working on this?
Has anyone reproduced the issue?
Has anyone tried bisecting the issue down to a specific git commit?

fba · May 2, 2024, 8:18pm

Hey @sgold I’ll take a look at this later tonight and see if I can help.

sgold · May 4, 2024, 3:53am

All eleven “Boss” geometries use PBR material, but there’s no light probe in the scene. To me, that seems like a bug in the test app. However, I added the “quarry_Probe.j3o” light probe (from jme3-testdata) to the scene, and it didn’t seem to help.

So far, I don’t understand why the test app renders better with JME 3.6.1 than with 3.7.0. One tempting explanation is that the material parameters are different. For instance, the “NormalScale” and “UseSpecularAA” parameters are both set with 3.7.0 but not with 3.6.1. However, clearing those parameters with 3.7.0 didn’t improve the render.

I’m now using bisection to track down the git commit(s) that are causing the issue.

adi.barda · May 4, 2024, 4:48am

Here we have some kind of optimization that might be related…

github.com/jMonkeyEngine/jmonkeyengine

Fix render states merging when additionalState is not set

jMonkeyEngine:master ← riccardobl:fixupdaterenderstate

opened 10:13PM - 01 Mar 24 UTC

riccardobl

+12 -10

While testing some pbr code, i've noticed that something was off with lighting, …after some convoluted debugging i've found that pr https://github.com/jMonkeyEngine/jmonkeyengine/commit/5975b3f791d18fae311a10e209b3ed40b5e5c60f introduced a bug. The tl;dr is that copyMergedTo changes the passed state when additionalState is set, but returns `this` when it isn't, causing mergedRenderState to not be updated at all. This PR restores the original behavior of passing the returned state to applyRenderState instead of mergedRenderState.

adi.barda · May 4, 2024, 4:58am

Edit: probably related to caching mechanism which was introduced in PR 2128

Hi @RiccardoBlb,
Can you take a look at the test-app I provided and see if the issue with the lighting / material is related to the big UBO/SSBO improvements PR that we integrated a few weeks ago?

github.com/jMonkeyEngine/jmonkeyengine

UBO/SSBO Improvements, Structs, BufferObject and sub data update

jMonkeyEngine:master ← riccardobl:ubo2

opened 09:33AM - 09 Mar 22 UTC

riccardobl

+4653 -1068

This PR is made by multiple parts that together are used to reimplement UBOs and… SSBOs in a more convenient and performant way. The main concepts are explained below ## BufferObject A BufferObject is a generic memory buffer that exists in OpenGL and from which all the other specialized buffers are derived. In JME we currently have some specialized Buffers (eg. VertexBuffer) but not a generic one. This is needed to implement UBOs and SSBOs and can be used as parent class for VertexBuffer in a future refactoring, unlocking some performance improvements (see below) ## BufferObject layout and sub data update This PR introduces the concept of buffer layout, this is an abstraction and doesn't exist in OpenGL, nevertheless it can be used in jme to split the buffer in logical regions that can be marked for update and efficiently pushed to the GPU by the renderer while leaving the rest of the buffer untouched. ## StructStd140BufferObject This is an abstraction on top of BufferObject and BufferObject layouts, it generates an updates a BufferObject from a specially defined object that implements the Struct interface. This makes the creation and update of buffer objects user friendly and matches perfectly the glsl side of the code when using UBO/SSBO. The goal when implementing this was to make it the default way to maintain BufferObjects (even inside the core), for this reason the implementation forces some limitations that are there to avoid any meaningful performance burden that might be caused by a more flexible implementation. The limitations are: - Only fields that are of one of the types defined in `com.jme3.util.struct.fields.*` are serialized: this permits to track changes to the fields and update only what changes - Every serializable field must be final : this allows the code to trust that the class layout will never change These limitations can be avoided by creating and maintaining the BufferObject manually with StructUtils, but shouldn't be needed in common usecases. ## Usage example This is an example and unit test for the UBO implementation - TestUBO.java: https://github.com/riccardobl/jmonkeyengine/blob/ef7982de9217dab3f95bc6fdcbbe0f846b896f77/jme3-examples/src/main/java/jme3test/material/TestUBO.java - TestUBO.frag: https://github.com/riccardobl/jmonkeyengine/blob/ef7982de9217dab3f95bc6fdcbbe0f846b896f77/jme3-examples/src/main/resources/jme3test/ubo/TestUBO.frag ## Final thoughts This PR solves all the issues in he current UBO/SSBO implementation and, thanks to the sub data update, should always result in a performance improvement over sparse uniforms. In future the bufferobject regions could be used to split large vertex buffers and allow a more efficient update (eg. for instances position). There is an important change from the previous proposal (https://github.com/jMonkeyEngine/jmonkeyengine/pull/1317) in the use of hardcoded `com.jme3.util.struct.fields.*` types, instead of a generic type StructField object, this is used to avoid ambiguity when using StructFields containing immutable types. In the previous proposal, two methods were used: - setValue() : to update immutable fields - getValueForUpdate() : to update mutable fields This is now handled internally by the `com.jme3.util.struct.fields.*` types.

I think your PRs are the only ones that might be related to this issue

sgold · May 4, 2024, 5:08am

I believe the issue is related to PR 2128, which was integrated in October.

Before 2128 was integrated (at Git hash 8fb016c) the loaded model looks OK.
After it was integrated (at Git hash 300d2a72) the loaded model has pitch-black slacks and a completely black face.

@tonihele can you help us debug this issue?

SwiftWolf · May 4, 2024, 5:36am

Hello…

Maybe I’m late, but I did some tests on a computer (Dell), the model loaded without problems. However, on my Linux/Windows laptop the model does not work (with the error present)

[ OUTPUT - JAVA ]

may 03, 2024 10:35:40 AM com.jme3.system.JmeDesktopSystem initialize
INFORMACI�N: Running on jMonkeyEngine 3.7.0-alpha3.1
 * Branch: HEAD
 * Git Hash: 0175ba2
 * Build Date: 2024-03-14
may 03, 2024 10:35:41 AM com.jme3.system.lwjgl.LwjglContext printContextInitInfo
INFORMACI�N: LWJGL 2.9.5 context running on thread jME3 Main
 * Graphics Adapter: aticfx64
 * Driver Version: 8.17.10.1698
 * Scaling Factor: 1
may 03, 2024 10:35:41 AM com.jme3.renderer.opengl.GLRenderer loadCapabilitiesCommon
INFORMACI�N: OpenGL Renderer Information
 * Vendor: ATI Technologies Inc.
 * Renderer: Radeon RX550/550 Series
 * OpenGL Version: 3.2.0 Core Profile Context 22.20.27.09.230330
 * GLSL Version: 4.60
 * Profile: Core
may 03, 2024 10:35:41 AM com.jme3.asset.AssetConfig loadText
ADVERTENCIA: Cannot find loader com.jme3.audio.plugins.OGGLoader
may 03, 2024 10:35:42 AM com.jme3.audio.openal.ALAudioRenderer initOpenAL
INFORMACI�N: Audio Renderer Information
 * Device: OpenAL Soft
 * Vendor: OpenAL Community
 * Renderer: OpenAL Soft
 * Version: 1.1 ALSOFT 1.15.1
 * Supported channels: 64
 * ALC extensions: ALC_ENUMERATE_ALL_EXT ALC_ENUMERATION_EXT ALC_EXT_CAPTURE ALC_EXT_DEDICATED ALC_EXT_disconnect ALC_EXT_EFX ALC_EXT_thread_local_context ALC_SOFT_loopback
 * AL extensions: AL_EXT_ALAW AL_EXT_DOUBLE AL_EXT_EXPONENT_DISTANCE AL_EXT_FLOAT32 AL_EXT_IMA4 AL_EXT_LINEAR_DISTANCE AL_EXT_MCFORMATS AL_EXT_MULAW AL_EXT_MULAW_MCFORMATS AL_EXT_OFFSET AL_EXT_source_distance_model AL_LOKI_quadriphonic AL_SOFT_buffer_samples AL_SOFT_buffer_sub_data AL_SOFTX_deferred_updates AL_SOFT_direct_channels AL_SOFT_loop_points AL_SOFT_source_latency
may 03, 2024 10:35:42 AM com.jme3.audio.openal.ALAudioRenderer initOpenAL
ADVERTENCIA: Pausing audio device not supported.
may 03, 2024 10:35:42 AM com.jme3.audio.openal.ALAudioRenderer initOpenAL
INFORMACI�N: Audio effect extension version: 1.0
may 03, 2024 10:35:42 AM com.jme3.audio.openal.ALAudioRenderer initOpenAL
INFORMACI�N: Audio max auxiliary sends: 4
may 03, 2024 10:35:42 AM com.jme3.bullet.objects.PhysicsRigidBody rebuildRigidBody
INFORMACI�N: Created 2414f94d210.
may 03, 2024 10:35:42 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:42 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:42 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:42 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:42 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:42 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:42 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:42 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:42 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.scene.plugins.gltf.GltfLoader readAnimation
ADVERTENCIA: JME only supports linear interpolation for animations
may 03, 2024 10:35:43 AM com.jme3.bullet.objects.PhysicsRigidBody rebuildRigidBody
INFORMACI�N: Created 24151f7e020.
may 03, 2024 10:35:43 AM com.jme3.anim.SkinningControl controlRender
INFORMACI�N: Hardware skinning engaged for Boss (Node)
may 03, 2024 10:35:43 AM com.jme3.anim.SkinningControl controlRender
INFORMACI�N: Hardware skinning engaged for Boss (Node)
may 03, 2024 10:35:43 AM com.jme3.anim.SkinningControl controlRender
INFORMACI�N: Hardware skinning engaged for Boss (Node)
may 03, 2024 10:35:43 AM com.jme3.anim.SkinningControl controlRender
INFORMACI�N: Hardware skinning engaged for Boss (Node)
may 03, 2024 10:35:43 AM com.jme3.anim.SkinningControl controlRender
INFORMACI�N: Hardware skinning engaged for Boss (Node)
may 03, 2024 10:35:43 AM com.jme3.anim.SkinningControl controlRender
INFORMACI�N: Hardware skinning engaged for Boss (Node)
may 03, 2024 10:35:43 AM com.jme3.anim.SkinningControl controlRender
INFORMACI�N: Hardware skinning engaged for Boss (Node)
may 03, 2024 10:35:43 AM com.jme3.anim.SkinningControl controlRender
INFORMACI�N: Hardware skinning engaged for Boss (Node)
may 03, 2024 10:35:43 AM com.jme3.anim.SkinningControl controlRender
INFORMACI�N: Hardware skinning engaged for Boss (Node)
may 03, 2024 10:35:43 AM com.jme3.anim.SkinningControl controlRender
INFORMACI�N: Hardware skinning engaged for Boss (Node)
may 03, 2024 10:35:43 AM com.jme3.anim.SkinningControl controlRender
INFORMACI�N: Hardware skinning engaged for Boss (Node)

It’s strange, regarding PR 2128; If I delete line ‘697’ the model loads without problems…

I hope this helps in some way…

tonihele · May 4, 2024, 6:53am

Sure, I can take a look tomorrow.

Might be an issue with material cloning… Maybe, just guessing.

fba · May 5, 2024, 9:29pm

I took a look at this issue. I found that if we remove line 697 of GltfLoader.java, the model is rendered as expected.

github.com

jMonkeyEngine/jmonkeyengine/blob/ec7f6e1f3304d3a6378393d0bb8c820996eed406/jme3-plugins/src/gltf/java/com/jme3/scene/plugins/gltf/GltfLoader.java#L697


      
              }
          
              Float occlusionStrength = occlusionJson != null ? getAsFloat(occlusionJson, "strength") : null;
              if (occlusionStrength != null) {
                  adapter.setParam("occlusionStrength", occlusionStrength);
              }
          
              adapter.setParam("emissiveTexture", readTexture(matData.getAsJsonObject("emissiveTexture")));
          
              material = adapter.getMaterial();
              addToCache("materials", materialIndex, material, materials.size());
          
              return material;
          }
          
          public void readCameras() throws IOException {
              if (cameras == null) {
                  return;
              }
              for (int i = 0; i < cameras.size(); i++) {
                  // Can't access resolution here... actually it's a shame we can't access settings from anywhere.

adi.barda · May 5, 2024, 9:56pm

But then we give up the material caching right? Let’s see what @tonihele thinks about it since this PR is about caching materials…

fba · May 5, 2024, 10:07pm

You’re right, I was not clear in my statement. What I actually mean is that something is not right with caching. I’m still trying to find a fix, but I thought that if I showed the line that causes the issue it would make it easier to @tonihele and others.

tonihele · May 6, 2024, 5:41am

Yeah, the problem is in material cloning. I was able to reproduce this yesterday but didn’t find any obvious solution.

Caching stuff in GltfLoader is done to prevent GLB loading to run out of memory. In GLBs the textures are built-in as bytes rather than separate image files. When reusing these in the model, it was slow and used up all the RAM. Some of the caching was there already before the GLB fixes, probably to get faster load times in all cases.

The material cache however might have been extra, I’m not sure anymore do we need to have it. Texture caching is more the key. But I’d still look why a material doesn’t work when cloned, that is most likely a real issue that might manifest elsewhere too…

tonihele · May 6, 2024, 6:20am

In this particular model the arms and face share the same material. Hat and the pants as well. The material only works on parts where it was first assigned to. But the cloned materials wont work.

tonihele · May 6, 2024, 7:03pm

Could not figure it out. Remove material cache, some materials seem not work when cloned by tonihele · Pull Request #2255 · jMonkeyEngine/jmonkeyengine · GitHub. Removing the material cloning slows the loader a bit, but the memory fixes are still ok. So I guess everything is relatively fine.

adi.barda · May 6, 2024, 8:03pm

There’s an issue with mac JDK 8 build. WDYT?

adi.barda · May 6, 2024, 8:09pm

Hey Guys,
I would like to ask any of you who can, to temporary switch your various JME related projects to v3.7.0-alpha3.1 and see that there is no regression (both in functionality and logs warnings / errors) it will greatly accelerate the release process. If everything looks fine we will move to beta1 version.
Thanks a lot!

sgold · May 6, 2024, 8:21pm

GitHub Actions recently changed its “macOS-latest” platform to “macOS 14 Arm64”, which doesn’t include JDK 8.

I’ve submitted PR 2254 to work around this.

codex · May 6, 2024, 9:08pm

So far I haven’t notices any regressions in my projects using 3.7-alpha3.1. I’ve also heavily used the new gpu accelerated environment baking, and have no complaints with it.