Management and Code Control

I suggest that you make a separate bored for code review. This form would be different then Dev General because it will only be for posting code not discussing future changes, meaning that all the first posts in a thread should have code.

Sounds good. A seperate board just for suggested code sounds nice. People just post it there, and everyone makes it pretty at the same time.

Ok, so, everyone hold off committing any new items/changes etc for awhile. Feel free to continue committing any bug fixes that crop up and minor things you feel need to be in sooner rather than later.



I’m going to finish up the clean up as discussed before. Then I am going to go and format everything using the same formatting. So, I’ll probably be touching every file.



Once that is complete, we’ll be ready to implement the next phase of jME’s life, one that will produce a very professional API.



I’m almost finished with my tasks, so I’ll keep people updated.

In a big open project like this you can often run the risk of “too many cooks” when it comes to architectural decisions. Especially if you do not have some kind of review system in place and someone or a few someones with “the final word” So, I definitely agree we need to move to some kind of system like that. Especially given all the talented contributions we’ve received of late (I’m glad we have the problem versus no contributions and no interest!)



I would like to suggest continuing Mojo as the central architect as he says, but I’d also like to see a few “generals” or “area specialists” under him to coordinate and provide a first level of defense before code reaches him for final approval. This should keep all the pressure from stacking on him espeically is on vacation or overwhelmed at work, etc. One project manager on a project of this size is fine if it’s a full time job, but obviously that can’t be the case here.



Having discussion forums act as review boards is not bad if we all are committed to reading every post, but I doubt that will happen, so having these area “specialists” would at least encourage participation from them for topics in their responsibility area.



So final summary, I definitely support the shift to a better managed architectural process and offer the above tweaks as suggestions only.

Oh don’t you worry, I’m the master of delegation… :stuck_out_tongue:

Having discussion forums act as review boards is not bad if we all are committed to reading every post, but I doubt that will happen, so having these area "specialists" would at least encourage participation from them for topics in their responsibility area.


We all don't have to read it, but we can at least have the chance too. Reviewing code is much easier than actually cleaning it up exactly, or programming it from scratch.

I suggest a template we fill out and post on a non-minor change. A template would make it easy for people to quickly review. Something like

Change title: <MD9 model loading>

Created classes: <MD9Converter>

Affected classes: <JmeBinaryReader, TriMesh, Controller>

Summary of changes: We now support MD9 with its UberTranslation algorithm. Added ability to Uberize TriMesh, as well as asplode aspect of every Controller.

Code:

TriMesh

public void loadMD9(){
System.out.println("BURNINATED");
}



JmeBinaryReader.loadXML()

..... <after reading part>
s.push(new Trogdor());
....