Pr1580

Development
1

This code initializes the settings dialog:

    AppSettings settings = new AppSettings(true);
    settings.setTitle(windowTitle);
    application.setSettings(settings);

    application.start();

I didn’t know that settings.setTitle even existed so when I didn’t find my game name I assumed it was a bug, hence the PR that adds precisely that line.

Shoud this be the default behavior?
Should jME automatically set the title based on the game’s name?

1 Like
2
  • Accept the PR and let JME save 1 line to lazy coders
  • Refuse the PR, the coders must specify each and every title

0 voters

2 Likes
3

I think no problem from having a default title, but If there would be a default behavior, it should be documented too.

1 Like
4

What name?

2 Likes
5

Oh, wow. Just realized that the whole issue is most likely caused because I’m using a forked SettingsDialog which is initialized differently. The PR should be discarded and this thread closed. Sorry!

1 Like