Quaternion.fromAngles() not returning a Quaternion

Small inconsistancy but probably easy to fix:



All the Quaternion.fromAngles() methods except Quaternion.fromAngles(float[] angles) return a new Quaternion for easy concatenating, while the latter one returns nothing.

They all set the value on the current Quaternion, so your parameter is your result.

Yes, but I think you don’t understand me. All the others except fromAngles(float[] angles) give the Quaternion itself back for chaining:



For example,



[java]waterPlane2.setLocalRotation(new Quaternion().fromAngles(-FastMath.HALF_PI, 0,0));

[/java]

does not work for the float[] angles version



[java]float angles[] = {-FastMath.HALF_PI, 0 , 0};

waterPlane2.setLocalRotation(new Quaternion().fromAngles(angles)); // this version of fromAngles does not return a Quat [/java]



so you have to



[java]float angles[] = {-FastMath.HALF_PI, 0 , 0};

Quaternion quat = new Quaternion();

quat.fromAngles(angles);

waterPlane2.setLocalRotation(angles);[/java]



only for that version.

Yes I did, but you were saying it was returning a “new” Quaternion, which is wrong. So I was not sure if you were aware of the fact that the actual Quaternion you perform the operation on contains the result afterwards.

Allright, ‘new’ was not entirely accurate :slight_smile:



Btw, is this the correct place to submit bugs and the like?

We like patches posted in the contributions forum better :wink: