Refactoring AppSettings

tonihele · August 10, 2015, 10:47am

Hi,

I’ve got this very simple problem and a proposition. Basically refactoring AppSettings.

Problem:
Maintaining global application settings & user settings separately. In different files. Whereas the global application settings would really have nothing to do with JME. But JME has nice handling of property files through AppSettings.java which I would like to use. And it is usable right now as well, just avoid generating the defaults. But hygiene!

Proposition:
Strip AppSettings of these generic property file handling stuff (saving, loading, reading…) and instead let AppSettings extend this newly founded utility class. Maybe not a very common use case but not a big change either and totally non-breaking one.

The original code I’m speaking of:

github.com

jMonkeyEngine/jmonkeyengine/blob/master/jme3-core/src/main/java/com/jme3/system/AppSettings.java

/*
 * Copyright (c) 2009-2020 jMonkeyEngine
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are
 * met:
 *
 * * Redistributions of source code must retain the above copyright
 *   notice, this list of conditions and the following disclaimer.
 *
 * * Redistributions in binary form must reproduce the above copyright
 *   notice, this list of conditions and the following disclaimer in the
 *   documentation and/or other materials provided with the distribution.
 *
 * * Neither the name of 'jMonkeyEngine' nor the names of its contributors
 *   may be used to endorse or promote products derived from this software
 *   without specific prior written permission.
 *
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS

This file has been truncated. show original

pspeed · August 10, 2015, 1:25pm

My recollection is that AppSettings is just using Java Preferences API… which you can use directly. No utility class needed really?

tonihele · August 10, 2015, 2:44pm

Yes it uses Preferences API. But it doesn’t expose it. And the format it produces is not the same. AppSettings has a nice way of handling types.

tonihele · August 10, 2015, 2:51pm

And it also uses Properties straight. That is where the types get in the game. And that is why it doesn’t expose anything except the HashMap that it is.