Should we ddd OptionPanelState to GuiGlobals?

Ali_RS · March 23, 2019, 6:18am

GuiGlobals adds PopupState by default

jMonkeyEngine-Contributions/Lemur/blob/2654d7aa7f70abfbf5e0d3cc2dabd61c810f9f47/src/main/java/com/simsilica/lemur/GuiGlobals.java#L156


if (app.getContext().getTouchInput() == null) {
    this.mouseState = new MouseAppState(app);
} else {
    this.touchState = new TouchAppState(app);
}
this.inputMapper = new InputMapper(app.getInputManager());
this.focusState = new FocusManagerState();
this.focusNavState = new FocusNavigationState(inputMapper, focusState);
this.animationState = new AnimationState();
this.popupState = new PopupState();
// Write the app state dependencies directly so that:
// a) they are there before initialization
// b) so that the states don't have to rely on GuiGlobals to find
//    them.
// c) so that we might disable them properly even at runtime
//    if the user kills or replaces the nav state
focusState.setFocusNavigationState(focusNavState);
app.getStateManager().attach(keyInterceptor);

but not the OptionPanelState. Should we add it also ?

pspeed · March 23, 2019, 8:59am

OptionPanelState is still in Lemur-proto. Until it moves to Lemur core it can’t be loaded by default in GuiGlobals.

OptionPanelState was written before PopupState… PopupState is the more general form of OptionPanelState’s core purpose. It needs to be cleaned up to just be a thin wrapper around OptionPanel and PopupState… then we can decide if it is worth still having and then move it to core.