Sim-Ethereal zone radius bug

JBuchi · September 18, 2017, 10:07pm

I have found a bug with Sim-Ethereal while experimenting with the sim-eth-es example. When changing the zone_radius in GameConstants.java the client gets incorrect position updates.

I stepped through the code and found the issue but it has already been fixed on master so maybe you could push a release?

While debugging i found another bug which only shows when using a zone_radius with different x and y extents:

github.com

Simsilica/SimEthereal/blob/master/src/main/java/com/simsilica/ethereal/LocalZoneIndex.java#L149


        return -1;
    }
    
    int xBase = center.x - xExtent;
    int yBase = center.y - yExtent;
    int zBase = center.z - zExtent;
    int x = zone.x - xBase;
    int y = zone.y - yBase;
    int z = zone.z - zBase;
    
    return minZoneId + z * (xSize * ySize) + y * xSize + x;   
}
    
public ZoneKey getCenter() {
    return center;
}
    
public boolean setCenter( Vec3d pos, List<ZoneKey> entered, List<ZoneKey> exited ) {
    ZoneKey key = grid.worldToKey(pos.x, pos.y, pos.z);
    return setCenter(key, entered, exited);        
}

This line should be corrected to:

return minZoneId + z * (xSize * ySize) + y * xSize + x;

pspeed · September 19, 2017, 6:18am

If it’s not too much trouble can you either file an issue on github or submit a PR?

Else I will try to get to this soon.

asser_fahrenholz · September 19, 2017, 3:45pm

You can get the latest using this gradle:

// And our base code for sim-etheral, SiO2, etc.
// (many of these need to be built locally and 'gradle install'ed as of this writing)
compile "com.simsilica:sio2:1.1.0"
compile "com.simsilica:sim-math:1.1.1"
compile 'com.github.Simsilica:SimEthereal:-SNAPSHOT' //There is an unreleased commit that we need

I had the same requirement as you it seems

FYI: The snapshot requires the versions of sio2 and sim-math listed as well - hence why I included them.

JBuchi · September 19, 2017, 4:44pm

Yes I’m using the same to get jme 3.2. But it’s slower on a gradle refresh and for some reason it doesn’t include the sources. But for now i’ll use that.

JBuchi · September 20, 2017, 1:05pm

Submitted a pull request:

JBuchi · September 24, 2017, 6:20pm

@pspeed Did you have time to look at it yet?

pspeed · September 24, 2017, 6:36pm

Not yet… sorry.

Life has me by the balls these days.