SimEthereal ZoneManager warning

asser_fahrenholz · December 30, 2020, 10:26pm

Not sure if this is supposed to happen, but I’m seeing a warning message from SimEthereal:

23:21:35,689 WARN [com.simsilica.ethereal.zone.ZoneManager] How would this ever happen: id:151 this.id:151

The code is this:

Simsilica/SimEthereal/blob/349f0b05b0a4ea911351db3555a464650d362f31/src/main/java/com/simsilica/ethereal/zone/ZoneManager.java#L1037


                enterZone(id, keys[i]);
            }       
        }

        @Override    
        public void leave( Long id ) {
            if( log.isDebugEnabled() ) {
                log.debug("DynamicZoneRange.leave(" + id + ")  keys:" + Arrays.asList(keys));
            }        
if( id != this.id ) {
    log.warn("How would this ever happen: id:" + id + "  this.id:" + this.id);
}            
            for( int i = 0; i < keyCount; i++ ) {
                leaveZone(id, keys[i]);
            }
        }                
 
        private void enterMissing( Long id, Vec3i minZone, Vec3i maxZone, ZoneKey[] zoneKeys, int count ) {
 
            // See which new zone keys are not in the current range
            for( int i = 0; i < count; i++ ) {

But, as the log shows, the id is actually the same, maybe not the same object? should the equality be .equals() instead of != ?

pspeed · December 30, 2020, 10:42pm

Yeah, probably should be Objects.equals().

…my only guess (without looking) is that maybe one or the other used to be regular “long” and the autoboxing took care of it. Or everything used to share the same pointer and then some autoboing passthrough made one of them different.

Either way, the code is wrong. You can safely ignore the warning. (Out-dented code like that, by my convention, is code I intend to remove or redo in the future anyway.)