Small bug in matrix uniform (jME2)

archive development-discussion-jme2
1

Hi, I been working on my hardware skinning system and noticed an oddity:

In ShaderVariableMatrix4, it writes the rowMajor variable as "transpose", but reads as "rowMajor". You wouldn't notice this problem unless you exported shaders as binary with transpose matrix4fs. Below is a diff patch to fix it.

diff patch wrote:
# This patch file was generated by NetBeans IDE
# Following Index: paths are relative to: E:ProjectsjME2srccomjmeutilshaderuniformtypes
# This patch can be applied using context Tools: Patch action on respective folder.
# It uses platform neutral UTF-8 encoding and n newlines.
# Above lines and this line are ignored by the patching process.
Index: ShaderVariableMatrix4.java
--- ShaderVariableMatrix4.java Base (BASE)
+++ ShaderVariableMatrix4.java Locally Modified (Based On LOCAL)
@@ -52,7 +52,7 @@
        OutputCapsule capsule = e.getCapsule(this);

        capsule.write(matrixBuffer, "matrixBuffer", null);
-        capsule.write(rowMajor, "transpose", false);
+        capsule.write(rowMajor, "rowMajor", false);
    }

    public void read(JMEImporter e) throws IOException {
2

Nice catch, transpose was renamed in this class to rowMajor in 2.0.  This location must have been missed.  Fixed in svn.