[Solved] Zay-ES (net) filter error when no entities has been added with given component type


#21

Yeah, this line:

Is invoking this constructor:

…which won’t take null because it wants to unbox the object.

I think it’s better to let the -1 through and then make sure the client detects it and doesn’t cache the value.

The problem is that I have no way to test this code because I tend to construct my apps in such a way as to avoid it.


#22

@pspeed can you take a look at this please ?

Now the result != null seems would never happen, should I get rid of it ?


#23

Umm… isn’t that for getting the string and not the id?

result should be a string in this case and might be null.

I thought your bug was related to this method:

…where you are trying to look up the integer ID for a string that hasn’t been registered yet.


#24

Oh, what a mistake , I did it in wrong place. Sorry gonna fix it.


#25

fixed in


#26

Have you tested it? :slight_smile:


#27

Yes :slightly_smiling_face:


#28

Merged and release note added.


#29

Are you going to release Zay-ES-Net v1.4.1 as hot fix ? Or you want to keep it until the next release iteration ?


#30

I’m just going to wait. So far this seems to have not affected many people.


#31

Also, I recently started added automated tests to SimMath… one of the places where they really do make sense.

I’ve been trying to think if there is a way to test stuff like this in an automated way. Network stuff is notoriously difficult to test in ‘unit test’ form factor but it’s on my mind. I’d like to think about it a little more before the next release.

Zay-ES core is another module that could really use some unit testing… like SimMath, it’s ripe for it because behavior is well defined and consistent. Zay-ES-Net is a little harder because there is no easy loopback mechanism and few places to inject one.