The Contribution Mega-Thread


#1

Since a recent discussion showed that some fellow monkeys would like to contribute to this project, but don’t know where to start in the forrest of issues/pr’s.
That’s why here everyone (mostly devs from the team) can post issues which require some sort of attention.

Note that the interaction still should take place on github for those and specifically I don’t want this thread to contain any posts commenting on issues. Every post should be an issue.


#2

Starting with https://github.com/jMonkeyEngine/jmonkeyengine/issues/942
What action is required? Running the test case on NON-QWERTY Keyboards with both lwjgl2 and 3 (code is provided, you only need to run the gradle build) and pressing the “z”/“y” key.


#3

Good one, @DarkChaos. That one’s high on my list as well.

Here’s another:

This currently needs investigation to help characterize the issue. Does it happen on all platforms? Is it only for certain graphics adapters or drivers?


#4

Mmmm… this thread is a good idea.

When we moved to github originally, I was promised by everyone who dragged me kicking and screaming that discussions like this would happen here. But they never really did and then those folks left the project. :smiley:


#5


Feel free to check this PR out (especially the Test where you can fire balls) and maybe also if it breaks your use-cases.

I had the issue sometimes that picking on a mountain in rare cases only led to a collision with the backside of the mountain. Can someone confirm if that was the case before that? Or did I break something?

Edit: Regression has been fixed, feel free to check the PR out and see if you find something that breaks. If you report it, please include the ray (origin and direction) and also make sure that you’ve commented out setLocalScale(2, 2, 2) in TerrainTestCollision, because otherwise I can’t reproduce the values.


#6

Here’s a very easy one, a 2-liner, in case someone wants practice creating pull requests:
https://github.com/jMonkeyEngine/jmonkeyengine/issues/1046

Issues like this are labelled with the “Easy first fix” label so people can find them by searching:
https://github.com/jMonkeyEngine/jmonkeyengine/labels/Easy%20first%20fix


#7

Thank you for posting it. I’ve made a pull request. I’ll also take a look at the second one.


#8

Hi,

I recently stumbled upon this issue an created a PR for it:


#9

Here’s another easy first fix:
https://github.com/jMonkeyEngine/jmonkeyengine/issues/1070


#10

Is there a 1070Ti as well? :stuck_out_tongue: