Declaring variable for mouse button index

mulova · October 2, 2010, 7:11am

There is no variable declared for mouse button index.

[patch]

Index: src/core/com/jme3/input/controls/MouseButtonTrigger.java

===================================================================

— src/core/com/jme3/input/controls/MouseButtonTrigger.java (revision 5882)

+++ src/core/com/jme3/input/controls/MouseButtonTrigger.java (working copy)

@@ -4,6 +4,9 @@

Mouse-button trigger.

*/

public class MouseButtonTrigger implements Trigger {

public static final int LEFT_BUTTON = 0;
public static final int RIGHT_BUTTON = 1;
public static final int MIDDLE_BUTTON = 2;

private final int mouseButton;

[/patch]

Momoko_Fan · October 2, 2010, 3:37pm

There is, but its in the MouseInput class.

mulova · October 2, 2010, 4:33pm

Example codes use 0, 1, 2. So I didn’t know about that. :eek:

To let others know, I suggest a patch for example codes.

[patch]

Index: src/test/jme3test/helloworld/HelloInput.java

===================================================================

— src/test/jme3test/helloworld/HelloInput.java (revision 5893)

+++ src/test/jme3test/helloworld/HelloInput.java (working copy)

@@ -7,6 +7,7 @@

import com.jme3.scene.shape.Box;

import com.jme3.math.ColorRGBA;

import com.jme3.input.KeyInput;

+import com.jme3.input.MouseInput;

import com.jme3.input.controls.ActionListener;

import com.jme3.input.controls.AnalogListener;

import com.jme3.input.controls.KeyTrigger;

@@ -40,7 +41,7 @@

inputManager.addMapping(“Left”, new KeyTrigger(KeyInput.KEY_J));

inputManager.addMapping(“Right”, new KeyTrigger(KeyInput.KEY_K));

inputManager.addMapping(“Rotate”, new KeyTrigger(KeyInput.KEY_SPACE), // spacebar!

                                 new MouseButtonTrigger(0) );        // left click!<br />

                                 new MouseButtonTrigger(MouseInput.BUTTON_LEFT) );        // left click!<br />

/** Add the named mappings to the action listeners. */

inputManager.addListener(actionListener, new String[]{“Pause”});

inputManager.addListener(analogListener, new String[]{“Left”, “Right”, “Rotate”});

Index: src/tools/jme3tools/preview/PreviewDisplay.java

===================================================================

— src/tools/jme3tools/preview/PreviewDisplay.java (revision 5893)

+++ src/tools/jme3tools/preview/PreviewDisplay.java (working copy)

@@ -1,6 +1,7 @@

package jme3tools.preview;

import com.jme3.app.Application;

+import com.jme3.input.MouseInput;

import com.jme3.input.controls.AnalogListener;

import com.jme3.input.controls.MouseAxisTrigger;

import com.jme3.input.controls.MouseButtonTrigger;

@@ -96,9 +97,9 @@

inputManager.addMapping(“MOUSE_W+”, new MouseAxisTrigger(2, false));

inputManager.addMapping(“MOUSE_W-”, new MouseAxisTrigger(2, true));

   inputManager.addMapping("MOUSE_LEFT", new MouseButtonTrigger(0));<br />

   inputManager.addMapping("MOUSE_RIGHT", new MouseButtonTrigger(1));<br />

   inputManager.addMapping("MOUSE_MIDDLE", new MouseButtonTrigger(2));<br />

   inputManager.addMapping("MOUSE_LEFT", new MouseButtonTrigger(MouseInput.BUTTON_LEFT));<br />

   inputManager.addMapping("MOUSE_RIGHT", new MouseButtonTrigger(MouseInput.BUTTON_RIGHT));<br />

   inputManager.addMapping("MOUSE_MIDDLE", new MouseButtonTrigger(MouseInput.BUTTON_MIDDLE));<br />

}

private Quaternion rot = new Quaternion();

Index: src/core/com/jme3/input/ChaseCamera.java

===================================================================

— src/core/com/jme3/input/ChaseCamera.java (revision 5893)

+++ src/core/com/jme3/input/ChaseCamera.java (working copy)

@@ -113,8 +113,8 @@

inputManager.addMapping(“ZoomOut”, new MouseAxisTrigger(2, false));

inputManager.addMapping(“mouseLeft”, new MouseAxisTrigger(0, true));

inputManager.addMapping(“mouseRight”, new MouseAxisTrigger(0, false));

   inputManager.addMapping("toggleRotate", new MouseButtonTrigger(0));<br />

   inputManager.addMapping("toggleRotate", new MouseButtonTrigger(1));<br />

   inputManager.addMapping("toggleRotate", new MouseButtonTrigger(MouseInput.BUTTON_LEFT));<br />

   inputManager.addMapping("toggleRotate", new MouseButtonTrigger(MouseInput.BUTTON_RIGHT));<br />

inputManager.addListener(this, inputs);

Index: src/test/jme3test/bullet/TestCcd.java
===================================================================
--- src/test/jme3test/bullet/TestCcd.java (revision 5893)
+++ src/test/jme3test/bullet/TestCcd.java (working copy)
@@ -5,6 +5,7 @@
import com.jme3.bullet.collision.shapes.MeshCollisionShape;
import com.jme3.bullet.collision.shapes.SphereCollisionShape;
import com.jme3.bullet.nodes.PhysicsNode;
+import com.jme3.input.MouseInput;
import com.jme3.input.controls.ActionListener;
import com.jme3.input.controls.MouseButtonTrigger;
import com.jme3.material.Material;
@@ -40,8 +41,8 @@
}

private void setupKeys() {
- inputManager.addMapping("shoot", new MouseButtonTrigger(0));
- inputManager.addMapping("shoot2", new MouseButtonTrigger(1));
+ inputManager.addMapping("shoot", new MouseButtonTrigger(MouseInput.BUTTON_LEFT));
+ inputManager.addMapping("shoot2", new MouseButtonTrigger(MouseInput.BUTTON_RIGHT));
inputManager.addListener(this, "shoot");
inputManager.addListener(this, "shoot2");
}
Index: src/test/jme3test/helloworld/HelloPhysics.java
===================================================================
--- src/test/jme3test/helloworld/HelloPhysics.java (revision 5893)
+++ src/test/jme3test/helloworld/HelloPhysics.java (working copy)
@@ -6,6 +6,7 @@
import com.jme3.bullet.collision.shapes.SphereCollisionShape;
import com.jme3.bullet.nodes.PhysicsNode;
import com.jme3.font.BitmapText;
+import com.jme3.input.MouseInput;
import com.jme3.input.controls.ActionListener;
import com.jme3.input.controls.MouseButtonTrigger;
import com.jme3.material.Material;
@@ -68,7 +69,7 @@
cam.lookAt(Vector3f.ZERO, new Vector3f(0, 1, 0));
cam.setFrustumFar(15);
/** Add shooting action */
- inputManager.addMapping("shoot", new MouseButtonTrigger(0));
+ inputManager.addMapping("shoot", new MouseButtonTrigger(MouseInput.BUTTON_LEFT));
inputManager.addListener(actionListener, "shoot");
/** Initialize the scene and physics space */
initMaterials();
Index: src/test/jme3test/bullet/TestCollisionListener.java
===================================================================
--- src/test/jme3test/bullet/TestCollisionListener.java (revision 5893)
+++ src/test/jme3test/bullet/TestCollisionListener.java (working copy)
@@ -9,6 +9,7 @@
import com.jme3.bullet.collision.shapes.MeshCollisionShape;
import com.jme3.bullet.collision.shapes.SphereCollisionShape;
import com.jme3.bullet.nodes.PhysicsNode;
+import com.jme3.input.MouseInput;
import com.jme3.input.controls.ActionListener;
import com.jme3.input.controls.MouseButtonTrigger;
import com.jme3.material.Material;
@@ -42,7 +43,7 @@
}

private void setupKeys() {
- inputManager.addMapping("shoot", new MouseButtonTrigger(0));
+ inputManager.addMapping("shoot", new MouseButtonTrigger(MouseInput.BUTTON_LEFT));
inputManager.addListener(this, "shoot");
}

Index: src/test/jme3test/helloworld/HelloPicking.java
===================================================================
--- src/test/jme3test/helloworld/HelloPicking.java (revision 5893)
+++ src/test/jme3test/helloworld/HelloPicking.java (working copy)
@@ -6,6 +6,7 @@
import com.jme3.collision.CollisionResults;
import com.jme3.font.BitmapText;
import com.jme3.input.KeyInput;
+import com.jme3.input.MouseInput;
import com.jme3.input.controls.ActionListener;
import com.jme3.input.controls.KeyTrigger;
import com.jme3.input.controls.MouseButtonTrigger;
@@ -52,7 +53,7 @@
private void initKeys() {
inputManager.addMapping("Shoot",
new KeyTrigger(KeyInput.KEY_SPACE), // trigger 1: spacebar
- new MouseButtonTrigger(0)); // trigger 2: left-button click
+ new MouseButtonTrigger(MouseInput.BUTTON_LEFT)); // trigger 2: left-button click
inputManager.addListener(actionListener, "Shoot");
}
/** Defining the "Shoot" action: Determine what was hit and how to respond. */
Index: src/core/com/jme3/input/FlyByCamera.java
===================================================================
--- src/core/com/jme3/input/FlyByCamera.java (revision 5893)
+++ src/core/com/jme3/input/FlyByCamera.java (working copy)
@@ -148,7 +148,7 @@
// mouse only - zoom in/out with wheel, and rotate drag
inputManager.addMapping("FLYCAM_ZoomIn", new MouseAxisTrigger(2, false));
inputManager.addMapping("FLYCAM_ZoomOut", new MouseAxisTrigger(2, true));
- inputManager.addMapping("FLYCAM_RotateDrag", new MouseButtonTrigger(0));
+ inputManager.addMapping("FLYCAM_RotateDrag", new MouseButtonTrigger(MouseInput.BUTTON_LEFT));

// keyboard only WASD for movement and WZ for rise/lower height
inputManager.addMapping("FLYCAM_StrafeLeft", new KeyTrigger(KeyInput.KEY_A));
Index: src/test/jme3test/bullet/TestPhysicsCharacter.java
===================================================================
--- src/test/jme3test/bullet/TestPhysicsCharacter.java (revision 5893)
+++ src/test/jme3test/bullet/TestPhysicsCharacter.java (working copy)
@@ -7,6 +7,7 @@
import com.jme3.bullet.nodes.PhysicsCharacterNode;
import com.jme3.bullet.nodes.PhysicsNode;
import com.jme3.input.KeyInput;
+import com.jme3.input.MouseInput;
import com.jme3.input.controls.ActionListener;
import com.jme3.input.controls.KeyTrigger;
import com.jme3.input.controls.MouseButtonTrigger;
@@ -48,7 +49,7 @@
inputManager.addMapping("Ups", new KeyTrigger(KeyInput.KEY_U));
inputManager.addMapping("Downs", new KeyTrigger(KeyInput.KEY_J));
inputManager.addMapping("Space", new KeyTrigger(KeyInput.KEY_SPACE));
- inputManager.addMapping("shoot", new MouseButtonTrigger(0));
+ inputManager.addMapping("shoot", new MouseButtonTrigger(MouseInput.BUTTON_LEFT));
inputManager.addListener(this, "shoot");
inputManager.addListener(this, "Lefts");
inputManager.addListener(this, "Rights");
Index: src/test/jme3test/bullet/TestBrickWall.java
===================================================================
--- src/test/jme3test/bullet/TestBrickWall.java (revision 5893)
+++ src/test/jme3test/bullet/TestBrickWall.java (working copy)
@@ -6,6 +6,7 @@
import com.jme3.bullet.collision.shapes.SphereCollisionShape;
import com.jme3.bullet.nodes.PhysicsNode;
import com.jme3.font.BitmapText;
+import com.jme3.input.MouseInput;
import com.jme3.input.controls.ActionListener;
import com.jme3.input.controls.MouseButtonTrigger;
import com.jme3.material.Material;
@@ -62,7 +63,7 @@
this.cam.setLocation(new Vector3f(0, 6f, 6f));
cam.lookAt(Vector3f.ZERO, new Vector3f(0, 1, 0));
cam.setFrustumFar(15);
- inputManager.addMapping("shoot", new MouseButtonTrigger(0));
+ inputManager.addMapping("shoot", new MouseButtonTrigger(MouseInput.BUTTON_LEFT));
inputManager.addListener(actionListener, "shoot");

rootNode.setShadowMode(ShadowMode.Off);

[/patch]

Momoko_Fan · October 2, 2010, 7:36pm

Thanks, I commited it in SVN