Could any developer with 2.0 baseline commit privs please comment out line 75 in http://jmonkeyengine.googlecode.com/svn/trunk/src/com/jme/scene/state/GLSLShaderObjectsState.java? This is not for my benefit, since I easily commented it out in my work area. It's so the baseline will build for other innocents out there. Doesn't help to recruit new JMonkey users if our baseline won't build.
Looks like mulova introduced the error this morning. He/she is not online now, and who knows when they will be back to fix it. Specifically, he/she added reference to class ShaderVariableMatrix4Array, which is not in the baseline (probably a local file in his/her work area).
Core-Dump said:
should be fixed already in r4110
http://code.google.com/p/jmonkeyengine/source/detail?r=4110
I see that he fixed it 10 minutes after my post. Don't know why the forum showed him as offline, since it's obvious he saw the post (the code being broken and untouched for 20 hours previously). Baseline building successfully again.
I'm really sorry about this.
It was my fault. I was so careless.
I am using another local patch of jme (http://www.jmonkeyengine.com/jmeforum/index.php?topic=9654.0)
Because it is not committed yet,
I removed the local patch and committed http://www.jmonkeyengine.com/jmeforum/index.php?topic=10601.0.
But import statement wasn't removed.
I promise I'll be more careful.
(I created new jme project(for patch test) and I'll do double check)
Sorry again.
blaine said:
I see that he fixed it 10 minutes after my post. Don't know why the forum showed him as offline, since it's obvious he saw the post (the code being broken and untouched for 20 hours previously). Baseline building successfully again.
Actually I found this mistake when checking the code in at another computer.
Maybe at that time, I wasn't online.
no worries here mulova; you made a mistake, you did your best to make it right (and it only took a little bit o time :))
(also, it appears that you learned from it, which is why we all need to make mistakes sometimes :))
basixs said:
no worries here mulova; you made a mistake, you did your best to make it right (and it only took a little bit o time :))
(also, it appears that you learned from it, which is why we all need to make mistakes sometimes :))
Right on. I think anybody who reads this thread will be impressed by how quickly mulova fixed the problem, and how he took the trouble to understand what happened.
blaine said:
basixs said:
no worries here mulova; you made a mistake, you did your best to make it right (and it only took a little bit o time :))
(also, it appears that you learned from it, which is why we all need to make mistakes sometimes :))
Right on. I think anybody who reads this thread will be impressed by how quickly mulova fixed the problem, and how he took the trouble to understand what happened.
It's so generous of you.
so I love jme guys. :D :) ;)