Input related crash

MoffKalast · January 14, 2018, 1:11am

A player of mine has reported an odd crash that I can’t make much of. It looks something like as if the mouse itself was null or something along those lines but that doesn’t really make sense.

Any ideas?

java.lang.NullPointerException
at net.java.games.input.RawMouse$Button.<init>(RawMouse.java:197)
at net.java.games.input.RawMouseInfo.createControllerFromDevice(RawMouseInfo.java:83)
at net.java.games.input.RawInputEnvironmentPlugin.createControllersFromDevices(RawInputEnvironmentPlugin.java:160)
at net.java.games.input.RawInputEnvironmentPlugin.enumControllers(RawInputEnvironmentPlugin.java:176)
at net.java.games.input.RawInputEnvironmentPlugin.<init>(RawInputEnvironmentPlugin.java:123)
at net.java.games.input.DirectAndRawInputEnvironmentPlugin.<init>(DirectAndRawInputEnvironmentPlugin.java:46)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at java.lang.Class.newInstance(Class.java:442)
at net.java.games.input.DefaultControllerEnvironment.getControllers(DefaultControllerEnvironment.java:160)
at com.jme3.input.lwjgl.JInputJoyInput.loadJoysticks(JInputJoyInput.java:84)
at com.jme3.input.InputManager.<init>(InputManager.java:146)
at com.jme3.app.LegacyApplication.initInput(LegacyApplication.java:344)
at com.jme3.app.LegacyApplication.initialize(LegacyApplication.java:601)
at com.jme3.app.SimpleApplication.initialize(SimpleApplication.java:178)
at com.jme3.system.lwjgl.LwjglAbstractDisplay.initInThread(LwjglAbstractDisplay.java:130)
at com.jme3.system.lwjgl.LwjglAbstractDisplay.run(LwjglAbstractDisplay.java:211)
at java.lang.Thread.run(Thread.java:745)

This is on jme 3.1-beta2, Windows 10, joysticks disabled, and the user claims to not have anything other than a mouse, keyboard and a headset plugged in. He also says he has no mouse/keyboard related issues otherwise.

Darkchaos · January 14, 2018, 10:12am

Well, the fun fact is:

github.com

jMonkeyEngine/jmonkeyengine/blob/v3.1.0-beta1/jme3-core/src/main/java/com/jme3/input/InputManager.java#L146



    this.keys = keys;
    this.mouse = mouse;
    this.joystick = joystick;
    this.touch = touch;

    keys.setInputListener(this);
    mouse.setInputListener(this);
    if (joystick != null) {
        joystick.setInputListener(this);
        joysticks = joystick.loadJoysticks(this);
    }
    if (touch != null) {
        touch.setInputListener(this);
    }

    firstTime = keys.getInputTimeNanos();
}

private void invokeActions(int hash, boolean pressed) {
    ArrayList<Mapping> maps = bindings.get(hash);

But even when the user has no joysticks there should be no exception.

github.com

jMonkeyEngine/jmonkeyengine/blob/v3.1.0-beta1/jme3-core/src/main/java/com/jme3/app/LegacyApplication.java#L344


    touchInput = context.getTouchInput();
    if (touchInput != null)
        touchInput.initialize();
    if (!settings.getBoolean("DisableJoysticks")){
        joyInput = context.getJoyInput();
        if (joyInput != null)
            joyInput.initialize();
    }
    inputManager = new InputManager(mouseInput, keyInput, joyInput, touchInput);
}
private void initStateManager(){
    stateManager = new AppStateManager(this);
    // Always register a ResetStatsState to make sure
    // that the stats are cleared every frame
    stateManager.attach(new ResetStatsState());
}

So your joysticks aren’t really disabled (It’s unrelated to that crash I guess, but just a hint).

And: This issue seems to happen from time to time:
see here

I think Gamepad :: The Count Lucanor General Discussions is helpful.

Can you maybe ask the user to launch the game with the mouse unplugged? Here it seems that a “Corsair Gaming Scimitar RGB Mouse” lead to the problem, because it was attempted to be read as Controller or something.

"Something to add… I can plug the mouse back in while in the game and the mouse and controller both continue to work, but when I exit and relaunch with the mouse plugged in, the controller no longer works. "

Edit: ha, in the other links the crash is also due to a corsair mouse

pspeed · January 14, 2018, 10:22am

And for what it’s worth, that joystick code wouldn’t run if joysticks were disabled because of the null check… the constructor of InputManager is called with a null joystick object if they are disabled.

See here:

github.com

jMonkeyEngine/jmonkeyengine/blob/v3.1.0-beta1/jme3-core/src/main/java/com/jme3/app/LegacyApplication.java#L338


        mouseInput.initialize();
    keyInput = context.getKeyInput();
    if (keyInput != null)
        keyInput.initialize();
    touchInput = context.getTouchInput();
    if (touchInput != null)
        touchInput.initialize();
    if (!settings.getBoolean("DisableJoysticks")){
        joyInput = context.getJoyInput();
        if (joyInput != null)
            joyInput.initialize();
    }
    inputManager = new InputManager(mouseInput, keyInput, joyInput, touchInput);
}
private void initStateManager(){
    stateManager = new AppStateManager(this);

Which is typically set to true by default:

github.com

jMonkeyEngine/jmonkeyengine/blob/v3.1.0-beta1/jme3-core/src/main/java/com/jme3/system/AppSettings.java#L153


  defaults.put("Height", 480);
  defaults.put("BitsPerPixel", 24);
  defaults.put("Frequency", 60);
  defaults.put("DepthBits", 24);
  defaults.put("StencilBits", 0);
  defaults.put("Samples", 0);
  defaults.put("Fullscreen", false);
  defaults.put("Title", JmeVersion.FULL_NAME);
  defaults.put("Renderer", LWJGL_OPENGL2);
  defaults.put("AudioRenderer", LWJGL_OPENAL);
  defaults.put("DisableJoysticks", true);
  defaults.put("UseInput", true);
  defaults.put("VSync", false);
  defaults.put("FrameRate", -1);
  defaults.put("SettingsDialogImage", "/com/jme3/app/Monkey.png");
  defaults.put("MinHeight", 0);
  defaults.put("MinWidth", 0);
  defaults.put("GammaCorrection", false);
  defaults.put("Resizable", false);
  defaults.put("SwapBuffers", true);
//  defaults.put("Icons", null);

Which is only set false here if called by the application or the settings dialog:

github.com

jMonkeyEngine/jmonkeyengine/blob/v3.1.0-beta1/jme3-core/src/main/java/com/jme3/system/AppSettings.java#L533


 */
public void setUseInput(boolean use) {
    putBoolean("UseInput", use);
}
/**
 * @param use If true, the application will initialize and use joystick
 * input. Set to false if no joystick input is desired.
 * (Default: false)
 */
public void setUseJoysticks(boolean use) {
    putBoolean("DisableJoysticks", !use);
}
/**
 * Set the graphics renderer to use, one of:<br>
 * <ul>
 * <li>AppSettings.LWJGL_OPENGL1 - Force OpenGL1.1 compatability</li>
 * <li>AppSettings.LWJGL_OPENGL2 - Force OpenGL2 compatability</li>
 * <li>AppSettings.LWJGL_OPENGL3 - Force OpenGL3.3 compatability</li>
 * <li>AppSettings.LWJGL_OPENGL_ANY - Choose an appropriate

So, I call “shenanigans” on the “joysticks are disabled” thing.

MoffKalast · January 14, 2018, 11:38am

@pspeed @Darkchaos Hmm I guess you guys are right. We set up launch parameters via steamworks to toggle it and it must’ve gotten disabled on his build somehow.

Mystery solved

Though it’s still a bit funny how fragile the input system is if it can’t handle no joysticks when they’re enabled.

pspeed · January 14, 2018, 12:19pm

It can handle them just fine. I have joysticks enabled by default in all of my apps and I only sometimes plug a joystick in.

The issue seems specific to this “mouse that acts like a joystick”, I guess. Maybe a bug in JInput.