KeyInputEvent.isRepeating not used anymore?

Documentation
1

Hi

KeyInputEvent docs says:

public boolean isRepeating()

Returns true if this event is a repeat event. Not used anymore.

I tried and it works as I expect - jME start spawning event with this flag after holding key for about half of a second.

What does mean “Not used anymore”?

2

I suspect it’s just wrong. The javadoc was added like that 9 years ago but all of the code that has ‘repeating’ information will pass that flag to the constructor of KeyInputEvent().

2 Likes
3

Can confirm. I’ve gone through the input code a few times and isRepeating is a common occurrence. It is most certainly still used.

1 Like
4

Is it ok to make such small PRs for every mistake (if it’s mistake, of course) I found in engine during developing of my game?

6 Likes
5

Constructive PRs are always welcome, no matter how small.

3 Likes
6

Small PRs are generally preferable to large ones - it’s easy to review, accept, discuss, correct, or reject small changes without having lots of changes causing noise or being affected by one small thing that needs changes or should be rejected.

3 Likes
7

I integrated the PR. Sorry this took so long!

2 Likes