The only part I am foggy with is I have Wiki privileges so I am not sure how GitHub handles a push from someone without them. I don’t know if GitHub will automatically place the push into the pull request tab for the Wiki on GitHub or if you will have to clone the wiki into your account, then clone that into the Atom editor.
I do know the Atom editor tracks all pull requests.
This is intended to make Wiki editing easy and open to the masses so we can get more contributors.
I have been using it for a few days now and find it to be AWESOME.
As part of the process the Wiki README.adoc has been updated.
I can’t install packages.
It seems that connection to ATOM download server is forbidden by GFW (Great Firewall of China).
So I cloned their source from github, and installed with npm install. it works for me.
Some module is missing
When restart ATOM, it told me that autocomplete-asciidoc and asciidoc-image-helper could not work because some module is missing. Maybe I should update my ATOM to lastest version.
Have no right to commit.
I don’t have primission to commit to jMonkeyEngine/wiki directly. I will edit in my own clone and make a PR when finished my work.
autocomplete-asciidoc requires autocomple-plus which is a default package. Check to make sure its active under File->settings->packages.
asciidoc-image-helper has no requirements but after reading how it works it should not be used so uninstall it. The problem is it doesn’t rely on the imagedir attribute you set in the document. Instead it uses a single image path you set in the settings for the package. This means it will dump all images into that image folder.
The wiki uses subfolders of the images folder that match the same file structure the adoc file is stored in. So asciidoc/advanced/jme3/myFile.adoc stores images under images/advanced/jme3/ for example.
Ok, that was what I expected might happen. Clone the repository first on github and use that for your changes.
Ill mention it on Atom forum and see if theres a workaround.
Before I post a question there, clone the wiki on github to your account, setup Atom to use that clone.
Make a small edit to a wiki page like src\docs\asciidoc\documentation_zh.adoc, push into your clone and lets see if it will become a pull request to the wiki.
Network is the biggest problem. I just cannot download some needed things from foreign server. Alway I got “connection timeout” or “connection is forbidden”.
That leads me to do things hand by hand. I use GitBash as my terminal.
As the ATOM told me which modules are missing, I go to the required folder and installed them.
First the autocomplete-asciidoc
$ cd /C/user/yan/.atom/packages
$ cd atom-autocomplete-asciidoc
$ npm install lodash
$ npm install season
Then the atom-asciidoc-image-helper
$ cd atom-asciidoc-image-helper
$ npm install atom-space-pen-views
By the way, I also installed “markdown2asciidoc” package. It doesn’t work because I installed python 3 and it wants python 2. That’s not really a problem.
