Next release of the Engine

[Ali_RS]

@sgold

Are there specific filters you wand added or updated?

I would like to name a few that I wish to see in JME (for creating cinematics)

1-Pencil portrait

https://i.imgur.com/qdTNes0.jpg

2-Sketch
https://i.imgur.com/UlzDuWu.jpg

3-Ink wash

https://i.imgur.com/tfmC7Fw.jpg

They are applied using G’MIC (it is open-source). You can try them online at https://gmicol.greyc.fr (under Black & white category).

[Pavl_G]

I think i can do these things :

For Android :

1. Deprecation of AndroidHarness to CompatHarness in which we use new compat package of androidx & remove trivial bugs plus adding some methods to the life cycle.
2. Adding the BufferedInputStream to the android packages ( & cleaning up code if needed).
3. Testing features on a physical device & on an emulator.

For Jme :

1. Helping in new Animation java docs & wiki.
2. May be adding new features to the animation system (like new blendSpaces) & code clean-up.
3. Testing features on PI.

[sgold]

Great! That’s the spirit.

Thank you.

[sgold]

@sgold

Meanwhile, UNLESS CONCERNS ARE PROMPTLY RAISED, I propose to designate myself as release manager for a v3.5 Engine release, the contents of said release still to be determined.

Here’s a proposed action plan for the release:

1. Create a “v3.5.0” Engine milestone at GitHub, without a due date.
2. Target closed issues and PRs to the new milestone if they’ve been solved/integrated since v3.4.

Having heard no concerns, I’m proceeding under the assumption that I’m the release manager for v3.5.0 of the Engine.

Steps 1 and 2 of the action plan have been completed.

[Pavl_G]

@Darkchaos

a cross-platform (android and desktop) gradle template

GitHub - Monkey-Droid/Cross-platform-template: A cross-platform template game...

Current limitations : for desktop
=> cannot include jme3 dependencies inside the output jar, when running the output jar, it gives ClassNotFound exception…any ideas ? – Seems the problem with the jme3 classes being not compiled to the build/classes to be jarred

Otherwise, coding inside android studio & running desktop & android along together using android studio is very fine.

[Ali_RS]

@Pavl_G

I hope someone would help me to achieve this.

Can you create a new topic for it, so it wont disrupt the current thread.

I have a bunch of suggestions and questions to ask.

[sgold]

@sgold

Here’s a proposed action plan for the release:

1. Create a “v3.5.0” Engine milestone at GitHub, without a due date.
2. Target closed issues and PRs to the new milestone if they’ve been solved/integrated since v3.4.
3. Open issues as needed for ideas that emerge (or have emerged) from this discussion.
4. Target open issues and PRs to the new milestone if they seem like promising candidates.

That plan got derailed because I was on vacation 26 October to 1 November. Also, many of the ideas discussed in this topic proved difficult to convert into GitHub issues, because either:

• they are too vague to be solved,
• I don’t understand them well enough to explain them to other developers, or
• they don’t relate to a particular GitHub repo.

I hate seeing issues and ideas get “dropped on the floor”, so if that’s happened to your idea, please speak up! I’d welcome further discussion of v3.5.0.

Currently we have 16 open issues targeted to v3.5.0:

• 1644: source files that lack javadoc
• 1640: CartoonEdgeFilter failing to override read() and write()
• 1634: Un-deprecate AndroidBufferImageLoader
• 1628: provide access to glscissors
• 1612: NPE while loading glTF model “Hover bike - The Rocket”
• 1596: GlfwKeyInput.getKeyName() doesn’t check for GLFW_KEY_UNKNOWN
• 1566: extraction of the inner class Layer -contained in the AnimComposer- in a separate class, with getter/setter methods for AnimationMask
• 1555: add interface to determine legal widths for OpenGL lines
• 1402: We need documentation for the new animation system.
• 1361: TestMultiRenderTarget renders a black display
• 1158: BitmapText right-to-left line wrapping not working
• 1128: the sample apps aren’t user-friendly
• 1098: CONTRIBUTION.md should be updated to specify what code style should be applied to PRs
• 1019: Missing features for AnimComposer and Action tween
• 781: GammaCorrectionFilter is deprecated in 3.2
• 357: Updating the frustum does not work as expected

For the latest list, see the issues page at GitHub.

I can’t promise that all these issues will be 100% solved in v3.5.0. I encourage those able to fix bugs and implement features to self-assign open issues. Please help!

Several of the issues already have pull requests in “draft” state or undergoing review. We currently have 15 open pull requests targeted to v3.5.0:

• 1643: solve issue 1555 (add API to determine max line width)
• 1642: improve the TransformTrack javadoc
• 1641: throw better exceptions in TransformTrack
• 1639: solve issue #1612 (NPE while importing from erroneous glTF)
• 1638: solve issue #1696 (missing check for GLFW_KEY_UNKNOWN)
• 1635: ignore return values from AnimMigrationUtils.migrate()
• 1633: Create a basic example that outlines a basic deferred rendering approach
• 1627: BufferedInputStream enhancement android
• 1626: New animation system docs
• 1625: Rework Test MultiRenderTarget to actually show how to use multiple
• 1616: Update examples to use new framebuffer apis
• 1607: fix incorrect input cursor position on MacOS with retina screen in use
• 1591: Test chooser
• 1471: avoid an NPE in GltfLoader.findChildren()
• 1317: Improved UBO/SSBO implementation

For the latest list, see the PRs page at GitHub.

I can’t promise that all these PRs will be integrated into v3.5.0 . I encourage those willing to review and/or discuss these changes to do so, either here or on GitHub. Please help!

I plan to wait at least another week before publishing an alpha version for testing. So there’s still time to submit new PRs and get them reviewed and integrated in time for v3.5.0-alpha1.

[JhonKkk]

@sgold

1361: TestMultiRenderTarget renders a black display

This case originally seemed to be written by a retired predecessor to test delayed rendering, but its content is missing. I rewritten this case to help newbies use MRT technology outside of jme.

[JhonKkk]

Fixed the example TestMultiRenderTarget #1645

[sgold]

So now we have 2 PRs for issue 1361, #1625 and #1645…

[JhonKkk]

It doesn’t matter, can it be changed to TestMultiRenderTarget2.java?

[sgold]

Sure, but first there is some review that must be resolved.

[Pavl_G]

A Maintenance PR for jmeSurfaceView.

I’d like to wait on CompatHarness PR until this PR is reviewed and merged, since changes here and there are very similar.

SurfaceView Maintenance

[Pavl_G]

An enhancement to the animation system PieChartSpace :

Pie chart blend space

[sgold]

I mean issues like these

Okay, I’ve proposed style guidelines for pull requests and created a PR to illustrate how they would work in practice.

If adopted, the proposed guidelines would impact everyone contributing to the Engine. I encourage potential contributors to review and comment on the proposal.

[sgold]

@sgold

Here’s a proposed action plan for the release:

1. Create a “v3.5.0” Engine milestone at GitHub, without a due date.
2. Target closed issues and PRs to the new milestone if they’ve been solved/integrated since v3.4.
3. Open issues as needed for ideas that emerge (or have emerged) from this discussion.
4. Target open issues and PRs to the new milestone if they seem like promising candidates.
5. Publish an alpha version for testing, with a list of changes since v3.4.0 .
6. Announce a feature-freeze date.

Step 5 is in progress. JmonkeyEngine v3.5.0-alpha1 is available from GitHub and Maven Central. The list of changes has been started but is not yet complete.

Testers: please begin testing v3.5.0-alpha1 and report any issues, either here or at GitHub.

The feature-freeze date for v3.5 isn’t set yet, but I promise it’s still at least a month away. Please continue discussing release content, developing code for new features, and reviewing pull requests.

[JhonKkk]

Sorry, today I noticed the message you gave me on Fixed the example TestMultiRenderTarget by JohnLKkk · Pull Request #1645 · jMonkeyEngine/jmonkeyengine · GitHub. I resubmitted based on the points you mentioned:
Improve TestMultiRenderTarget2 test Demo by JohnLKkk · Pull Request #1654 · jMonkeyEngine/jmonkeyengine · GitHub

[xuan]

@sgold

Testers: please begin testing v3.5.0-alpha1 and report any issues, either here or at GitHub

I was experiencing the deleteNativeObject() crash with 3.4 and since I upgraded to the alpha today I haven’t seen it so far and I did not see any regression.

[sgold]

That’s great news, since I’m considering a v3.4.1 release in December.

[sgold]

Hey! I see that LWJGL 3.3.0 was released today. Should we try to use it in JME 3.5?