Proposed fix for issue #614

May I commit this patch to the JME trunk?

# This patch file was generated by NetBeans IDE
# It uses platform neutral UTF-8 encoding and \n newlines.
--- Base (BASE)
+++ Locally Modified (Based On LOCAL)
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2009-2012 jMonkeyEngine
+ * Copyright (c) 2009-2014 jMonkeyEngine
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -149,7 +149,7 @@
         KEY_NAMES[KEY_BACK] = "Backspace";
         KEY_NAMES[KEY_TAB] = "Tab";
         
-        KEY_NAMES[KEY_SYSRQ] = "SysEq";
+        KEY_NAMES[KEY_SYSRQ] = "SysRq";
         KEY_NAMES[KEY_PAUSE] = "Pause";
         
         KEY_NAMES[KEY_HOME] = "Home";
2 Likes

btw the affected class is com.jme3.input.KeyNames

Sure, maybe remove the date change for now, we might go over that with search/replace at some point… Though i guess theres multiple dates already. You’ll also have to commit to the gradle-restructure branch as it will become trunk as soon as I have some spare time again ^^

I’ll add you to the committers list, should have your mail from the contrib repo still.

1 Like

I’m even fine with the date fix. (Technically it’s only really supposed to be changed when the file is updated anyway but open source ‘compilations’ are a bit weird in this respect anyway.)

I’m listed as a committer for the jmonkeyengine, and I successfully checked out a working copy using the IDE and my Google Code password. But each time I try to commit a change to the gradle-restructure branch, I get “Authentication failed” from the IDE. I’ve tried retyping my password. Same result when I attempt to commit to trunk. My password still works for other GC projects.

I also attempted to commit using TortoiseSVN 1.7.13 and got an error 405 (Method Not Allowed) from the server every time.

Perhaps Google Code is having issues tonight. I’ll try again tomorrow.

@sgold said: I'm listed as a committer for the jmonkeyengine, and I successfully checked out a working copy using the IDE and my Google Code password. But each time I try to commit a change to the gradle-restructure branch, I get "Authentication failed" from the IDE. I've tried retyping my password. Same result when I attempt to commit to trunk. My password still works for other GC projects.

I also attempted to commit using TortoiseSVN 1.7.13 and got an error 405 (Method Not Allowed) from the server every time.

Perhaps Google Code is having issues tonight. I’ll try again tomorrow.

Did you check out with http or https? You must check out with https if you want to modify stuff.

1 Like

Good point! I probably used http. I’ll check out a new tree and try again.

That’s better. The fix (without the date change) is in for trunk and gradle-restrcture. (Though I was unable to test it in the gradle-restructure branch.)

I can’t figure out how to close the issue at Google Code. Does that require extra privilege?

3 Likes

Should’n sgold get his contributor badge in the forums btw?

@Empire Phoenix said: Should'n sgold get his contributor badge in the forums btw?
Heh good point. I stopped doing them during my extended hiatus, so there's a bunch of contributors who are overdue... I'll jot down some names in the next couple of days.

Also closed this issue
Thanks.

2 Likes