[SOLVED] SkyControl phase does not seem to save

ndebruyn · April 18, 2025, 5:31pm

Working on a new game in which I noticed that the Phase is not being saved and it seems to always jump back to LunarPhase.FULL.

@sgold , can you confirm that it is the case or am I smoking my socks?

I am using version 1.1.0 with jME 3.7.0

sgold · April 18, 2025, 6:14pm

I studied the read() and write() code in “SkyControl.java”, and it looks perfect to me. I think the next step would be to write a simple test case. Before I do so, it would help to know whether you are serializing to J3O or XML or some other format.

ndebruyn · April 18, 2025, 6:19pm

I am serializing the j3o.
Thanks for looking at this.
I have a suspicion that it could be related to the clone().
Because in my editor, I clone the full scene to have it tested and at that point the phase also resets.

sgold · April 18, 2025, 6:23pm

Alright, I’ll look at cloning and test that as well.

sgold · April 19, 2025, 12:00am

I added an automated test, which didn’t find any problems with cloning/loading/saving the phase field:

github.com/stephengold/SkyControl

SkyLibrary/src/test/java/jme3utilities/sky/test/TestClone.java

master

/*
 Copyright (c) 2025 Stephen Gold

 Redistribution and use in source and binary forms, with or without
 modification, are permitted provided that the following conditions are met:
 * Redistributions of source code must retain the above copyright
 notice, this list of conditions and the following disclaimer.
 * Redistributions in binary form must reproduce the above copyright
 notice, this list of conditions and the following disclaimer in the
 documentation and/or other materials provided with the distribution.
 * Neither the name of the copyright holder nor the names of its contributors
 may be used to endorse or promote products derived from this software without
 specific prior written permission.

 THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
 ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
 WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
 DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
 FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
 DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR

This file has been truncated. show original

Admittedly I only tested with JME 3.8, so the issue might be specific to 3.7 .

I think the next step is for you to write a simple test that demonstrates the issue you’re seeing.

ndebruyn · April 19, 2025, 7:01am

Thanks for your investigation and effort on this.
I found a place in my code after referencing all usages of SkyControl where I actually parse the scene and for some reason, I have forced set the phase.
Man, rookie mistake. I am so sorry.

This problem was solved.

sgold · April 19, 2025, 2:48pm

I enjoy collaborating with you, and I’m glad you found the bug.