Suggestion of adding ed.removeComponents()

User Code & Projects zay-es
1

Hi

It would be nice to add EntityData.removeComponents(EntityId entityId, Class<T>... types) for ease of removing multiple components at once in Zay-ES.

Currently, I am doing something like:

Stream.of(ComponentA.class, ComponentB.class, ComponentC.class)
                        .forEach(component -> ed.removeComponent(eId, component));
2

I submitted a PR

@pspeed I would like to hear your opinion

3

It seems fine. I havenā€™t really had a chance to look at it yet.

ā€¦itā€™s just a convenience method, right? (No special complications in the implementation I assume.)

Edit: just lookedā€¦ I prefer not to hide code in interfaces. Itā€™s one thing when the method does basically nothing but this is real code. Iā€™ll keep this discussion on the PR, though. Sorry.

4

Applied the requested changes.

1 Like
5 
public void removeComponents( EntityId entityId, Class<? extends EntityComponent>... types );

IDE shows an ā€œUnchecked generics array creation for varargs parameterā€ hint when using ed.removeComponents().

Appears that I can not add @SafeVarargs on interface method.

Do I need to do something about it?

6

This is a pain with generics. Isnā€™t there a similar setComponents() method? Does it have a similar issue or did I resolve it somehow?

7

It does not have this issue because it does not use generics

public void setComponents( EntityId entityId, EntityComponent... components );
8

Ah, so one approach would be just to take naked Class and cast internallyā€¦ let the class cast exception bubble out.

I donā€™t know how I feel about that but generics leaves little good choice in this caseā€¦ and at least this gets rid of the warnings for every caller.

9

Yeah, seems you are also doing this for other methods:

10

Updated PR to use the naked class as you suggested and this fixed the warning.

I think it is now ready to be merged.

1 Like