Town.zip in Hello Collision missing

1

The link to the town.zip in https://jmonkeyengine.github.io/wiki/jme3/beginner/hello_collision.html points to a non existing location.
Can somebody correct this or give me the link of the github project of this wiki - I seem to be too stupid to find it, I only could find the old from @erlend_sh - and the new location of town.zip so I could maybe fix this?

2

As well Hello Terrain and Hello Effects lacks some important pictures - there are only place holders…

3

Fixed. Thanks for reporting.

4

Thanks for fixing! :smile:

5

https://jmonkeyengine.github.io/wiki/jme3/beginner/hello_collision.html
is still pointing to
http://jmonkeyengine.googlecode.com/svn/trunk/engine/town.zip

here:
“Sample Code
If you don’t have it yet, download the town.zip sample scene.”

and here:
“The file town.zip is included as a sample model in the JME3 sources – you can download it here.”

You can also see in the source https://github.com/jMonkeyEngine/wiki/blob/master/src/docs/asciidoc/jme3/beginner/hello_collision.adoc that is clearly hasnt been corrected.

@Ali_RS, could you please to the following:

git clone GitHub - jMonkeyEngine/wiki: The official wiki for jMonkeyEngine.
cd wiki
grep -r googlecode .
grep -r code.google.com .

and fix the links.

Currently there are 200+ broken links.

$ grep -r googlecode . | wc
43 355 9004
$ grep -r code.google.com . | wc
175 1372 42055

I can also do this if you give me commit access or promise to integrate my pull request if I do it.

Towns.zip can be found here:
https://web.archive.org/web/*/http://jmonkeyengine.googlecode.com/svn/trunk/engine/town.zip

Could you please add it to the github repo - or explain why it is missing ?

Thanks in advance,

Jacob

6

It is out of my access to invite other users but i have permission to merger others PRs.
@david_bernard_31 invited me to wiki and has full access to repo. He can give you the permission.

I will merge it, promise you.
Before adding any we should first MAKE SURE @coredevelopers are agree with.

I already made a PR to add Town.zip and was considering to fix broken links to town.zip after it has been merged, but it never merged and later because of my mistake that PR was ruined anyway and i closed it.

The question is TO WHERE SHOULD I UPLOAD THAT FILE ?

7

Why not into the github project of the wiki (I was too stupid to finde the repo btw)?

8

Just a note: GIT is a really horrible place to store binaries. It’s less bad when it never changes, though. However, if we were ever to update that zip then anyone cloning the repo would be downloading every full version of that file.

I’d check bintray’s policy on this sort of thing. Even though we can’t release it as a maven resource, there should be some other way to release it on bintray.

9

Hello,

Just a note: town.zip is also being used by the jmonkey example project:
Try a grep -r town.zip jmonkeyengine and you’ll get

jmonkeyengine/sdk/JME3TestsTemplate/src/jme3test/asset/TestManyLocators.java:        am.registerLocator("town.zip", ZipLocator.class);
jmonkeyengine/sdk/JME3TestsTemplate/src/jme3test/asset/TestManyLocators.java:            System.out.println("Failed to load from town.zip");
jmonkeyengine/sdk/JME3TestsTemplate/src/jme3test/asset/TestOnlineJar.java:        assetManager.registerLocator("http://jmonkeyengine.googlecode.com/files/town.zip",
jmonkeyengine/sdk/JME3TestsTemplate/src/jme3test/helloworld/HelloCollision.java:    assetManager.registerLocator("town.zip", ZipLocator.class);

Therefore I think it shouldnt be part of the wiki, but part of the repo that contains the jmonkey example project.
As far as I can see town.zip should be in the root folder of the test projekt (i.e. in jmonkeyengine/sdk/JME3TestsTemplate/) for the commant assetManager.registerLocator(“town.zip”, ZipLocator.class); to work

10

@pspeed the file is 640kb and never changes (have a look at Wayback Machine )

In jmonkeyengine/jme3-testdata/src/main/ is already 91MB of other test data.
I would say that the file belongs to there.

Jacob

11

I am agree too.