Trivial method signature change needed for SimpleApplication.simpleInitApp

mulova · September 25, 2010, 5:14am

It’s not related to functionality.

simpleInitApp shouldn’t be called from outside.

So access modifier need to be changed from public to protected

[patch]

Index: src/tools/jme3tools/optimize/TestOctree.java

===================================================================

— src/tools/jme3tools/optimize/TestOctree.java (revision 5849)

+++ src/tools/jme3tools/optimize/TestOctree.java (working copy)

@@ -33,7 +33,7 @@

app.start();

}

public void simpleInitApp() {

protected void simpleInitApp() {

this.flyCam.setMoveSpeed(2000);

this.cam.setFrustumFar(10000);

MeshLoader.AUTO_INTERLEAVE = false;

Index: src/games/jme3game/cubefield/CubeField.java

===================================================================

— src/games/jme3game/cubefield/CubeField.java (revision 5849)

+++ src/games/jme3game/cubefield/CubeField.java (working copy)

@@ -54,7 +54,7 @@

Initializes game

*/

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

Logger.getLogger(“com.jme3”).setLevel(Level.WARNING);

flyCam.setEnabled(false);

Index: src/core/com/jme3/app/SimpleApplication.java

===================================================================

— src/core/com/jme3/app/SimpleApplication.java (revision 5849)

+++ src/core/com/jme3/app/SimpleApplication.java (working copy)

@@ -186,7 +186,7 @@

simpleRender(renderManager);

}

public abstract void simpleInitApp();

protected abstract void simpleInitApp();

public void simpleUpdate(float tpf){

}

Index: src/test/jme3test/app/SwingCanvasTest.java

===================================================================

— src/test/jme3test/app/SwingCanvasTest.java (revision 5849)

+++ src/test/jme3test/app/SwingCanvasTest.java (working copy)

@@ -22,7 +22,7 @@

public class SwingCanvasTest extends SimpleApplication {

@Override

public void simpleInitApp() {

+protected void simpleInitApp() {

// activate windowed input behaviour

flyCam.setDragToRotate(true);

// display a cube

Index: src/test/jme3test/collision/TestSimpleCollision.java

===================================================================

— src/test/jme3test/collision/TestSimpleCollision.java (revision 5849)

+++ src/test/jme3test/collision/TestSimpleCollision.java (working copy)

@@ -23,7 +23,7 @@

}

@Override
public void simpleInitApp() {

protected void simpleInitApp() {

// Sphere q = new Sphere(32, 32, 2);

Quad q = new Quad(5, 5);

Index: src/test/jme3test/collision/TestRayCasting.java

===================================================================

— src/test/jme3test/collision/TestRayCasting.java (revision 5849)

+++ src/test/jme3test/collision/TestRayCasting.java (working copy)

@@ -24,7 +24,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

// flyCam.setEnabled(false);

// load material

Index: src/test/jme3test/export/TestAssetLinkNode.java

===================================================================

— src/test/jme3test/export/TestAssetLinkNode.java (revision 5849)

+++ src/test/jme3test/export/TestAssetLinkNode.java (working copy)

@@ -34,7 +34,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

AssetLinkNode loaderNode=new AssetLinkNode();

loaderNode.addLinkedChild(new AssetKey(“Models/MonkeyHead/MonkeyHead.mesh.xml”));

//load/attach the children (happens automatically on load)

Index: src/test/jme3test/export/TestOgreConvert.java

===================================================================

— src/test/jme3test/export/TestOgreConvert.java (revision 5849)

+++ src/test/jme3test/export/TestOgreConvert.java (working copy)

@@ -25,7 +25,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

Spatial ogreModel = assetManager.loadModel(“Models/Oto/Oto.mesh.xml”);

DirectionalLight dl = new DirectionalLight();

Index: src/test/jme3test/post/TestFBOPassthrough.java

===================================================================

— src/test/jme3test/post/TestFBOPassthrough.java (revision 5849)

+++ src/test/jme3test/post/TestFBOPassthrough.java (working copy)

@@ -30,7 +30,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

int w = settings.getWidth();

int h = settings.getHeight();

Index: src/test/jme3test/post/TestSSAO.java

===================================================================

— src/test/jme3test/post/TestSSAO.java (revision 5849)

+++ src/test/jme3test/post/TestSSAO.java (working copy)

@@ -36,7 +36,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

// put the camera in a bad position

cam.setLocation(new Vector3f(-2.336393f, 11.91392f, -7.139601f));

cam.setRotation(new Quaternion(0.23602544f, 0.11321983f, -0.027698677f, 0.96473104f));

Index: src/test/jme3test/post/TestRenderToMemory.java

===================================================================

— src/test/jme3test/post/TestRenderToMemory.java (revision 5849)

+++ src/test/jme3test/post/TestRenderToMemory.java (working copy)

@@ -204,7 +204,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

setupOffscreenView();

createDisplayFrame();

}

Index: src/test/jme3test/post/TestLightScattering.java

===================================================================

— src/test/jme3test/post/TestLightScattering.java (revision 5849)

+++ src/test/jme3test/post/TestLightScattering.java (working copy)

@@ -49,7 +49,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

// put the camera in a bad position

cam.setLocation(new Vector3f(55.35316f, -0.27061665f, 27.092093f));

cam.setRotation(new Quaternion(0.010414706f, 0.9874893f, 0.13880467f, -0.07409228f));

Index: src/test/jme3test/post/TestRenderToTexture.java

===================================================================

— src/test/jme3test/post/TestRenderToTexture.java (revision 5849)

+++ src/test/jme3test/post/TestRenderToTexture.java (working copy)

@@ -67,7 +67,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

cam.setLocation(new Vector3f(3, 3, 3));

cam.lookAt(Vector3f.ZERO, Vector3f.UNIT_Y);

Index: src/test/jme3test/post/TestHDR.java

===================================================================

— src/test/jme3test/post/TestHDR.java (revision 5849)

+++ src/test/jme3test/post/TestHDR.java (working copy)

@@ -35,7 +35,7 @@

// private Material disp;

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

hdrRender = new HDRRenderer(assetManager, renderer);

hdrRender.setSamples(0);

hdrRender.setMaxIterations(20);

Index: src/test/jme3test/post/TestPostFilters.java

===================================================================

— src/test/jme3test/post/TestPostFilters.java (revision 5849)

+++ src/test/jme3test/post/TestPostFilters.java (working copy)

@@ -110,7 +110,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

cam.setLocation(new Vector3f(-32.295086f, 54.80136f, 79.59805f));

cam.setRotation(new Quaternion(0.074364014f, 0.92519957f, -0.24794696f, 0.27748522f));

cam.update();

Index: src/test/jme3test/post/TestSSAO2.java

===================================================================

— src/test/jme3test/post/TestSSAO2.java (revision 5849)

+++ src/test/jme3test/post/TestSSAO2.java (working copy)

@@ -39,7 +39,7 @@

sphere.setLocalTranslation(cam.getLocation());

}

public void simpleInitApp() {

protected void simpleInitApp() {

this.flyCam.setMoveSpeed(10);

cam.setLocation(new Vector3f(6.0344796f, 1.5054002f, 55.572033f));

cam.setRotation(new Quaternion(0.0016069f, 0.9810479f, -0.008143323f, 0.19358753f));

Index: src/test/jme3test/light/TestManyLights.java

===================================================================

— src/test/jme3test/light/TestManyLights.java (revision 5849)

+++ src/test/jme3test/light/TestManyLights.java (working copy)

@@ -11,7 +11,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

flyCam.setMoveSpeed(10);

Node scene = (Node) assetManager.loadModel(“Scenes/ManyLights/Main.scene”);

Index: src/test/jme3test/light/TestPssmShadow.java

===================================================================

— src/test/jme3test/light/TestPssmShadow.java (revision 5849)

+++ src/test/jme3test/light/TestPssmShadow.java (working copy)

@@ -34,7 +34,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

// put the camera in a bad position

cam.setLocation(new Vector3f(-9.919669f, 29.182112f, -31.980177f));

cam.setRotation(new Quaternion(0.14896771f, 0.22304894f, -0.034511957f, 0.96273917f));

Index: src/test/jme3test/light/TestLightRadius.java

===================================================================

— src/test/jme3test/light/TestLightRadius.java (revision 5849)

+++ src/test/jme3test/light/TestLightRadius.java (working copy)

@@ -25,7 +25,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

Torus torus = new Torus(10, 6, 1, 3);

// Torus torus = new Torus(50, 30, 1, 3);

Geometry g = new Geometry(“Torus Geom”, torus);

Index: src/test/jme3test/light/TestSimpleLighting.java

===================================================================

— src/test/jme3test/light/TestSimpleLighting.java (revision 5849)

+++ src/test/jme3test/light/TestSimpleLighting.java (working copy)

@@ -24,7 +24,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

Geometry teapot = (Geometry) assetManager.loadModel(“Models/Teapot/Teapot.obj”);

TangentBinormalGenerator.generate(teapot.getMesh(), true);

Index: src/test/jme3test/light/TestTangentGen.java

===================================================================

— src/test/jme3test/light/TestTangentGen.java (revision 5849)

+++ src/test/jme3test/light/TestTangentGen.java (working copy)

@@ -27,7 +27,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

Sphere sphereMesh = new Sphere(32, 32, 1);

sphereMesh.setTextureMode(Sphere.TextureMode.Projected);

sphereMesh.updateGeometry(32, 32, 1, false, false);

Index: src/test/jme3test/light/TestTangentGenBadUV.java

===================================================================

— src/test/jme3test/light/TestTangentGenBadUV.java (revision 5849)

+++ src/test/jme3test/light/TestTangentGenBadUV.java (working copy)

@@ -24,7 +24,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

Spatial teapot = assetManager.loadModel(“Models/Teapot/Teapot.obj”);

if (teapot instanceof Geometry){

Geometry g = (Geometry) teapot;

Index: src/test/jme3test/light/TestShadow.java

===================================================================

— src/test/jme3test/light/TestShadow.java (revision 5849)

+++ src/test/jme3test/light/TestShadow.java (working copy)

@@ -36,7 +36,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

// put the camera in a bad position

cam.setLocation(new Vector3f(0.7804813f, 1.7502685f, -2.1556435f));

cam.setRotation(new Quaternion(0.1961598f, -0.7213164f, 0.2266092f, 0.6243975f));

Index: src/test/jme3test/terrain/TerrainTest.java

===================================================================

— src/test/jme3test/terrain/TerrainTest.java (revision 5849)

+++ src/test/jme3test/terrain/TerrainTest.java (working copy)

@@ -48,7 +48,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

setupKeys();

// First, we load up our textures and the heightmap texture for the terrain

Index: src/test/jme3test/model/anim/TestAnimBlendBug.java

===================================================================

— src/test/jme3test/model/anim/TestAnimBlendBug.java (revision 5849)

+++ src/test/jme3test/model/anim/TestAnimBlendBug.java (working copy)

@@ -54,7 +54,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

inputManager.addMapping(“One”, new KeyTrigger(KeyInput.KEY_1));

inputManager.addListener(this, “One”);

Index: src/test/jme3test/model/anim/TestOgreComplexAnim.java

===================================================================

— src/test/jme3test/model/anim/TestOgreComplexAnim.java (revision 5849)

+++ src/test/jme3test/model/anim/TestOgreComplexAnim.java (working copy)

@@ -27,7 +27,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

flyCam.setMoveSpeed(10f);

cam.setLocation(new Vector3f(6.4013605f, 7.488437f, 12.843031f));

cam.setRotation(new Quaternion(-0.060740203f, 0.93925786f, -0.2398315f, -0.2378785f));

Index: src/test/jme3test/model/anim/TestOgreAnim.java

===================================================================

— src/test/jme3test/model/anim/TestOgreAnim.java (revision 5849)

+++ src/test/jme3test/model/anim/TestOgreAnim.java (working copy)

@@ -26,7 +26,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

flyCam.setMoveSpeed(10f);

cam.setLocation(new Vector3f(6.4013605f, 7.488437f, 12.843031f));

cam.setRotation(new Quaternion(-0.060740203f, 0.93925786f, -0.2398315f, -0.2378785f));

Index: src/test/jme3test/model/shape/TestCylinder.java

===================================================================

— src/test/jme3test/model/shape/TestCylinder.java (revision 5849)

+++ src/test/jme3test/model/shape/TestCylinder.java (working copy)

@@ -15,7 +15,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

Cylinder t = new Cylinder(20, 50, 1, 2, true);

Geometry geom = new Geometry(“Cylinder”, t);

Index: src/test/jme3test/model/shape/TestDebugShapes.java

===================================================================

— src/test/jme3test/model/shape/TestDebugShapes.java (revision 5849)

+++ src/test/jme3test/model/shape/TestDebugShapes.java (working copy)

@@ -46,7 +46,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

cam.setLocation(new Vector3f(2,1.5f,2));

cam.lookAt(Vector3f.ZERO, Vector3f.UNIT_Y);

Index: src/test/jme3test/model/shape/TestBox.java

===================================================================

— src/test/jme3test/model/shape/TestBox.java (revision 5849)

+++ src/test/jme3test/model/shape/TestBox.java (working copy)

@@ -16,7 +16,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

Box b = new Box(Vector3f.ZERO, 1, 1, 1);

Geometry geom = new Geometry(“Box”, b);

Material mat = new Material(assetManager, “Common/MatDefs/Misc/SimpleTextured.j3md”);

Index: src/test/jme3test/model/shape/TestSphere.java

===================================================================

— src/test/jme3test/model/shape/TestSphere.java (revision 5849)

+++ src/test/jme3test/model/shape/TestSphere.java (working copy)

@@ -14,7 +14,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

Sphere sphMesh = new Sphere(14, 14, 1);

Material solidColor = (Material) assetManager.loadAsset(“Common/Materials/RedColor.j3m”);

Index: src/test/jme3test/model/TestObjLoading.java

===================================================================

— src/test/jme3test/model/TestObjLoading.java (revision 5849)

+++ src/test/jme3test/model/TestObjLoading.java (working copy)

@@ -14,7 +14,7 @@

app.start();

}

public void simpleInitApp() {

protected void simpleInitApp() {

// create the geometry and attach it

Geometry teaGeom = (Geometry) assetManager.loadModel(“Models/Teapot/Teapot.obj”);

Index: src/test/jme3test/model/TestOgreLoading.java

===================================================================

— src/test/jme3test/model/TestOgreLoading.java (revision 5849)

+++ src/test/jme3test/model/TestOgreLoading.java (working copy)

@@ -28,7 +28,7 @@

app.start();

}

public void simpleInitApp()

protected void simpleInitApp()

{

// PointLight pl = new PointLight();

// pl.setPosition(new Vector3f(10, 10, -10));

Index: src/test/jme3test/model/TestMonkeyHead.java

===================================================================

— src/test/jme3test/model/TestMonkeyHead.java (revision 5849)

+++ src/test/jme3test/model/TestMonkeyHead.java (working copy)

@@ -24,7 +24,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

viewPort.setBackgroundColor(ColorRGBA.DarkGray);

Spatial bumpy = (Spatial) assetManager.loadModel(“Models/MonkeyHead/MonkeyHead.mesh.xml”);

Index: src/test/jme3test/helloworld/HelloInput.java

===================================================================

— src/test/jme3test/helloworld/HelloInput.java (revision 5849)

+++ src/test/jme3test/helloworld/HelloInput.java (working copy)

@@ -23,7 +23,7 @@

Boolean isRunning=true;

@Override

public void simpleInitApp() {

+protected void simpleInitApp() {

Box b = new Box(Vector3f.ZERO, 1, 1, 1);

player = new Geometry(“Player”, b);

Material mat = new Material(assetManager, “Common/MatDefs/Misc/SolidColor.j3md”);

Index: src/test/jme3test/helloworld/HelloJME3.java

===================================================================

— src/test/jme3test/helloworld/HelloJME3.java (revision 5849)

+++ src/test/jme3test/helloworld/HelloJME3.java (working copy)

@@ -18,7 +18,7 @@

}

@Override
public void simpleInitApp() {

protected void simpleInitApp() {

Box b = new Box(Vector3f.ZERO, 1, 1, 1); // take a cube shape

Geometry geom = new Geometry(“Box”, b); // create a Spatial from it

Material mat = new Material(assetManager,

Index: src/test/jme3test/helloworld/HelloMaterial.java

===================================================================

— src/test/jme3test/helloworld/HelloMaterial.java (revision 5849)

+++ src/test/jme3test/helloworld/HelloMaterial.java (working copy)

@@ -24,7 +24,7 @@

}

@Override

public void simpleInitApp() {

+protected void simpleInitApp() {

/** A simple textured cube – in good MIP map quality. */

Box boxshape1 = new Box(new Vector3f(-3f,1.1f,0f), 1f,1f,1f);

Index: src/test/jme3test/helloworld/HelloLoop.java

===================================================================

— src/test/jme3test/helloworld/HelloLoop.java (revision 5849)

+++ src/test/jme3test/helloworld/HelloLoop.java (working copy)

@@ -19,7 +19,7 @@

protected Geometry player;

@Override
public void simpleInitApp() {

protected void simpleInitApp() {

/** this blue box is our player character */

Box b = new Box(Vector3f.ZERO, 1, 1, 1);

player = new Geometry(“blue cube”, b);

Index: src/test/jme3test/helloworld/HelloPicking.java

===================================================================

— src/test/jme3test/helloworld/HelloPicking.java (revision 5849)

+++ src/test/jme3test/helloworld/HelloPicking.java (working copy)

@@ -32,7 +32,7 @@

Geometry mark;

@Override

public void simpleInitApp() {

+protected void simpleInitApp() {

initCrossHairs(); // a “+” in the middle of the screen to help aiming

initKeys(); // load custom key mappings

initMark(); // a red sphere to mark the hit

Index: src/test/jme3test/helloworld/HelloNode.java

===================================================================

— src/test/jme3test/helloworld/HelloNode.java (revision 5849)

+++ src/test/jme3test/helloworld/HelloNode.java (working copy)

@@ -19,7 +19,7 @@

}

@Override
public void simpleInitApp() {

protected void simpleInitApp() {

/** create a blue box at coordinates (1,-1,1) */

Box box1 = new Box( new Vector3f(1,-1,1), 1,1,1);

Index: src/test/jme3test/helloworld/HelloAnimation.java

===================================================================

— src/test/jme3test/helloworld/HelloAnimation.java (revision 5849)

+++ src/test/jme3test/helloworld/HelloAnimation.java (working copy)

@@ -28,7 +28,7 @@

}

@Override

public void simpleInitApp() {

+protected void simpleInitApp() {

viewPort.setBackgroundColor(ColorRGBA.LightGray);

initKeys();

Index: src/test/jme3test/helloworld/HelloAssets.java

===================================================================

— src/test/jme3test/helloworld/HelloAssets.java (revision 5849)

+++ src/test/jme3test/helloworld/HelloAssets.java (working copy)

@@ -19,7 +19,7 @@

}

@Override
public void simpleInitApp() {

protected void simpleInitApp() {

/** Load a teapot model (OBJ file from test-data) */

Spatial teapot = assetManager.loadModel(“Models/Teapot/Teapot.obj”);

Index: src/test/jme3test/helloworld/HelloEffects.java

===================================================================

— src/test/jme3test/helloworld/HelloEffects.java (revision 5849)

+++ src/test/jme3test/helloworld/HelloEffects.java (working copy)

@@ -16,7 +16,7 @@

}

@Override

public void simpleInitApp() {

+protected void simpleInitApp() {

ParticleEmitter fire = new ParticleEmitter(“Emitter”, ParticleMesh.Type.Triangle, 30);

Material mat_red = new Material(assetManager, “Common/MatDefs/Misc/Particle.j3md”);

Index: src/test/jme3test/water/TestSimpleWater.java

===================================================================

— src/test/jme3test/water/TestSimpleWater.java (revision 5849)

+++ src/test/jme3test/water/TestSimpleWater.java (working copy)

@@ -41,7 +41,7 @@

}

@Override
public void simpleInitApp() {

protected void simpleInitApp() {

initInput();

initScene();

Index: src/test/jme3test/water/TestSceneWater.java

===================================================================

— src/test/jme3test/water/TestSceneWater.java (revision 5849)

+++ src/test/jme3test/water/TestSceneWater.java (working copy)

@@ -45,7 +45,7 @@

sphere.setLocalTranslation(cam.getLocation());

}

public void simpleInitApp() {

protected void simpleInitApp() {

this.flyCam.setMoveSpeed(10);

Node mainScene=new Node();

cam.setLocation(new Vector3f(-27.0f, 1.0f, 75.0f));

Index: src/test/jme3test/network/TestRemoteCall.java

===================================================================

— src/test/jme3test/network/TestRemoteCall.java (revision 5849)

+++ src/test/jme3test/network/TestRemoteCall.java (working copy)

@@ -35,7 +35,7 @@

public static void createServer(){

serverApp = new SimpleApplication() {

@Override

       public void simpleInitApp() {<br />

  	protected void simpleInitApp() {<br />

}

};

serverApp.start();

Index: src/test/jme3test/texture/TestNormalLatc.java

===================================================================

— src/test/jme3test/texture/TestNormalLatc.java (revision 5849)

+++ src/test/jme3test/texture/TestNormalLatc.java (working copy)

@@ -41,7 +41,7 @@

return quad;

}

public void simpleInitApp() {

protected void simpleInitApp() {

BitmapFont font = assetManager.loadFont(“Interface/Fonts/Default.fnt”);

BitmapText txt = new BitmapText(font, false);

txt.setText(“Left: LATC, Middle: JPG, Right: DXT1nm”);

Index: src/test/jme3test/texture/TestDdsLoading.java

===================================================================

— src/test/jme3test/texture/TestDdsLoading.java (revision 5849)

+++ src/test/jme3test/texture/TestDdsLoading.java (working copy)

@@ -15,7 +15,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

// create a simple plane/quad

Quad quadMesh = new Quad(1, 1);

Index: src/test/jme3test/texture/TestCubeMap.java

===================================================================

— src/test/jme3test/texture/TestCubeMap.java (revision 5849)

+++ src/test/jme3test/texture/TestCubeMap.java (working copy)

@@ -95,7 +95,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

initHDR();

loadEnvMap();

setupSkyBox();

Index: src/test/jme3test/texture/TestYCoCgDds.java

===================================================================

— src/test/jme3test/texture/TestYCoCgDds.java (revision 5849)

+++ src/test/jme3test/texture/TestYCoCgDds.java (working copy)

@@ -41,7 +41,7 @@

return quad;

}

public void simpleInitApp() {

protected void simpleInitApp() {

BitmapFont font = assetManager.loadFont(“Interface/Fonts/Default.fnt”);

BitmapText txt = new BitmapText(font, false);

txt.setText(“Left: Original, Middle: DXT5-YCoCg, Right: DXT1”);

Index: src/test/jme3test/scene/TestSceneLoading.java

===================================================================

— src/test/jme3test/scene/TestSceneLoading.java (revision 5849)

+++ src/test/jme3test/scene/TestSceneLoading.java (working copy)

@@ -35,7 +35,7 @@

sphere.setLocalTranslation(cam.getLocation());

}

public void simpleInitApp() {

protected void simpleInitApp() {

this.flyCam.setMoveSpeed(10);

// load sky

Index: src/test/jme3test/input/TestControls.java

===================================================================

— src/test/jme3test/input/TestControls.java (revision 5849)

+++ src/test/jme3test/input/TestControls.java (working copy)

@@ -27,7 +27,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

// Test multiple inputs per mapping

inputManager.addMapping(“My Action”,

new KeyTrigger(KeyInput.KEY_SPACE),

Index: src/test/jme3test/input/TestChaseCamera.java

===================================================================

— src/test/jme3test/input/TestChaseCamera.java (revision 5849)

+++ src/test/jme3test/input/TestChaseCamera.java (working copy)

@@ -24,7 +24,7 @@

app.start();

}

public void simpleInitApp() {

protected void simpleInitApp() {

// Load a teapot model

teaGeom = (Geometry) assetManager.loadModel(“Models/Teapot/Teapot.obj”);

Material mat = new Material(assetManager, “Common/MatDefs/Misc/ShowNormals.j3md”);

Index: src/test/jme3test/asset/TestUrlLoading.java

===================================================================

— src/test/jme3test/asset/TestUrlLoading.java (revision 5849)

+++ src/test/jme3test/asset/TestUrlLoading.java (working copy)

@@ -21,7 +21,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

// create a simple plane/quad

Quad quadMesh = new Quad(1, 1);

quadMesh.updateGeometry(1, 1, true);

Index: src/test/jme3test/asset/TestOnlineJar.java

===================================================================

— src/test/jme3test/asset/TestOnlineJar.java (revision 5849)

+++ src/test/jme3test/asset/TestOnlineJar.java (working copy)

@@ -24,7 +24,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

// create a simple plane/quad

Quad quadMesh = new Quad(1, 1);

quadMesh.updateGeometry(1, 1, true);

Index: src/test/jme3test/renderer/TestParallelProjection.java

===================================================================

— src/test/jme3test/renderer/TestParallelProjection.java (revision 5849)

+++ src/test/jme3test/renderer/TestParallelProjection.java (working copy)

@@ -20,7 +20,7 @@

app.start();

}

public void simpleInitApp() {

protected void simpleInitApp() {

Geometry teaGeom = (Geometry) assetManager.loadModel(“Models/Teapot/Teapot.obj”);

DirectionalLight dl = new DirectionalLight();

Index: src/test/jme3test/renderer/TestMultiViews.java

===================================================================

— src/test/jme3test/renderer/TestMultiViews.java (revision 5849)

+++ src/test/jme3test/renderer/TestMultiViews.java (working copy)

@@ -16,7 +16,7 @@

app.start();

}

public void simpleInitApp() {

protected void simpleInitApp() {

// create the geometry and attach it

Geometry teaGeom = (Geometry) assetManager.loadModel(“Models/Teapot/Teapot.obj”);

teaGeom.scale(3);

Index: src/test/jme3test/conversion/TestTriangleStrip.java

===================================================================

— src/test/jme3test/conversion/TestTriangleStrip.java (revision 5849)

+++ src/test/jme3test/conversion/TestTriangleStrip.java (working copy)

@@ -16,7 +16,7 @@

app.start();

}

public void simpleInitApp() {

protected void simpleInitApp() {

Geometry teaGeom = (Geometry) assetManager.loadModel(“Models/Teapot/Teapot.obj”);

Mesh teaMesh = teaGeom.getMesh();

ModelConverter.generateStrips(teaMesh, true, false, 24, 0);

Index: src/test/jme3test/conversion/TestMipMapGen.java

===================================================================

— src/test/jme3test/conversion/TestMipMapGen.java (revision 5849)

+++ src/test/jme3test/conversion/TestMipMapGen.java (working copy)

@@ -17,7 +17,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

BitmapText txt = guiFont.createLabel(“Left: HW Mips”);

txt.setLocalTranslation(0, txt.getLineHeight() * 4, 0);

guiNode.attachChild(txt);

Index: src/test/jme3test/niftygui/TestNiftyToMesh.java

===================================================================

— src/test/jme3test/niftygui/TestNiftyToMesh.java (revision 5849)

+++ src/test/jme3test/niftygui/TestNiftyToMesh.java (working copy)

@@ -22,7 +22,7 @@

app.start();

}

public void simpleInitApp() {

protected void simpleInitApp() {

ViewPort niftyView = renderManager.createPreView(“NiftyView”, new Camera(1024, 768));

niftyView.setClearEnabled(true);

NiftyJmeDisplay niftyDisplay = new NiftyJmeDisplay(assetManager,

Index: src/test/jme3test/niftygui/TestNiftyGui.java

===================================================================

— src/test/jme3test/niftygui/TestNiftyGui.java (revision 5849)

+++ src/test/jme3test/niftygui/TestNiftyGui.java (working copy)

@@ -17,7 +17,7 @@

app.start();

}

public void simpleInitApp() {

protected void simpleInitApp() {

Box b = new Box(Vector3f.ZERO, 1, 1, 1);

Geometry geom = new Geometry(“Box”, b);

Material mat = new Material(assetManager, “Common/MatDefs/Misc/SimpleTextured.j3md”);

Index: src/test/jme3test/material/TestSimpleBumps.java

===================================================================

— src/test/jme3test/material/TestSimpleBumps.java (revision 5849)

+++ src/test/jme3test/material/TestSimpleBumps.java (working copy)

@@ -25,7 +25,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

Quad quadMesh = new Quad(1, 1);

Geometry sphere = new Geometry(“Rock Ball”, quadMesh);

Index: src/test/jme3test/material/TestBumpModel.java

===================================================================

— src/test/jme3test/material/TestBumpModel.java (revision 5849)

+++ src/test/jme3test/material/TestBumpModel.java (working copy)

@@ -25,7 +25,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

Spatial signpost = (Spatial) assetManager.loadAsset(new OgreMeshKey(“Models/Sign Post/Sign Post.mesh.xml”, null));

signpost.setMaterial( (Material) assetManager.loadAsset(new AssetKey(“Models/Sign Post/Sign Post.j3m”)));

rootNode.attachChild(signpost);

Index: src/test/jme3test/material/TestColoredTexture.java

===================================================================

— src/test/jme3test/material/TestColoredTexture.java (revision 5849)

+++ src/test/jme3test/material/TestColoredTexture.java (working copy)

@@ -20,7 +20,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

Quad quadMesh = new Quad(512,512);

Geometry quad = new Geometry(“Quad”, quadMesh);

quad.setQueueBucket(Bucket.Gui);

Index: src/test/jme3test/material/TestNormalMapping.java

===================================================================

— src/test/jme3test/material/TestNormalMapping.java (revision 5849)

+++ src/test/jme3test/material/TestNormalMapping.java (working copy)

@@ -24,7 +24,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

Sphere sphMesh = new Sphere(32, 32, 1);

sphMesh.setTextureMode(Sphere.TextureMode.Projected);

sphMesh.updateGeometry(32, 32, 1, false, false);

Index: src/test/jme3test/stress/TestLodStress.java

===================================================================

— src/test/jme3test/stress/TestLodStress.java (revision 5849)

+++ src/test/jme3test/stress/TestLodStress.java (working copy)

@@ -18,7 +18,7 @@

app.start();

}

public void simpleInitApp() {

protected void simpleInitApp() {

// inputManager.registerKeyBinding(“USELOD”, KeyInput.KEY_L);

Node teapotNode = (Node) assetManager.loadModel(“Models/Teapot/Teapot.mesh.xml”);

Index: src/test/jme3test/stress/TestLeakingGL.java

===================================================================

— src/test/jme3test/stress/TestLeakingGL.java (revision 5849)

+++ src/test/jme3test/stress/TestLeakingGL.java (working copy)

@@ -27,7 +27,7 @@

app.start();

}

public void simpleInitApp() {

protected void simpleInitApp() {

original = new Sphere(4, 4, 1);

original.setStatic();

original.setInterleaved();

Index: src/test/jme3test/effect/TestEverything.java

===================================================================

— src/test/jme3test/effect/TestEverything.java (revision 5849)

+++ src/test/jme3test/effect/TestEverything.java (working copy)

@@ -163,7 +163,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

cam.setLocation(new Vector3f(-32.295086f, 54.80136f, 79.59805f));

cam.setRotation(new Quaternion(0.074364014f, 0.92519957f, -0.24794696f, 0.27748522f));

cam.update();

Index: src/test/jme3test/effect/TestMovingParticle.java

===================================================================

— src/test/jme3test/effect/TestMovingParticle.java (revision 5849)

+++ src/test/jme3test/effect/TestMovingParticle.java (working copy)

@@ -24,7 +24,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

emit = new ParticleEmitter(“Emitter”, Type.Triangle, 200);

emit.setGravity(0);

emit.setVariation(1);

Index: src/test/jme3test/effect/TestParticleEmitter.java

===================================================================

— src/test/jme3test/effect/TestParticleEmitter.java (revision 5849)

+++ src/test/jme3test/effect/TestParticleEmitter.java (working copy)

@@ -15,7 +15,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

ParticleEmitter emit = new ParticleEmitter(“Emitter”, Type.Triangle, 200);

emit.setShape(new EmitterSphereShape(Vector3f.ZERO, 1f));

emit.setGravity(0);

Index: src/test/jme3test/effect/TestExplosionEffect.java

===================================================================

— src/test/jme3test/effect/TestExplosionEffect.java (revision 5849)

+++ src/test/jme3test/effect/TestExplosionEffect.java (working copy)

@@ -187,7 +187,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

createFlame();

createFlash();

createSpark();

Index: src/test/jme3test/gui/TestBitmapFont.java

===================================================================

— src/test/jme3test/gui/TestBitmapFont.java (revision 5849)

+++ src/test/jme3test/gui/TestBitmapFont.java (working copy)

@@ -16,7 +16,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

BitmapFont fnt = assetManager.loadFont(“Interface/Fonts/Default.fnt”);

BitmapText txt = new BitmapText(fnt, false);

txt.setBox(new Rectangle(0, 0, settings.getWidth(), settings.getHeight()));

Index: src/test/jme3test/gui/TestBitmapText3D.java

===================================================================

— src/test/jme3test/gui/TestBitmapText3D.java (revision 5849)

+++ src/test/jme3test/gui/TestBitmapText3D.java (working copy)

@@ -19,7 +19,7 @@

}

@Override

public void simpleInitApp() {

protected void simpleInitApp() {

Quad q = new Quad(6, 3);

Geometry g = new Geometry(“quad”, q);

g.setLocalTranslation(0, -3, -0.0001f);

Index: src/test/jme3test/gui/TestOrtho.java

===================================================================

— src/test/jme3test/gui/TestOrtho.java (revision 5849)

+++ src/test/jme3test/gui/TestOrtho.java (working copy)

@@ -11,7 +11,7 @@

app.start();

}

public void simpleInitApp() {

protected void simpleInitApp() {

Picture p = new Picture(“Picture”);

p.move(0, 0, -1); // make it appear behind stats view

p.setPosition(0, 0);

Index: src/test/jme3test/gui/TestZOrder.java

===================================================================

— src/test/jme3test/gui/TestZOrder.java (revision 5849)

+++ src/test/jme3test/gui/TestZOrder.java (working copy)

@@ -10,7 +10,7 @@

app.start();

}

public void simpleInitApp() {

protected void simpleInitApp() {

Picture p = new Picture(“Picture1”);

p.move(0,0,-1);

p.setPosition(100, 100);

[/patch]

Momoko_Fan · September 25, 2010, 7:53pm

It is a trivial change, but with many consequences

If we do that, then virtually all code using jME3 will need to make a change. I guess its okay though since we are still in alpha though.

normen · September 26, 2010, 12:21am

I dont think its very important at all… When would you have a situation presenting any problems?

mulova · September 26, 2010, 2:04am

I have no problem at all.

I just want jME3 to be perfect in all aspects.

hazmat · September 26, 2010, 11:56am

Visibility should probably be protected unless someone can make the use-case for it to be public.

The change is less of a problem for jME users than for jME devs, but the diff covers the out-of-the-box test cases. Everyone else is just left to patch up their 1 or 2 applications.