I’ve just created a PR to update the wiki to version 3.8. This is the first time I’ve done this so I wanted to confirm I’d done everything correctly:
- I’ve created a new branch for the old version V3.4
- I’ve created PR at #181 create 3.8 wiki version by richardTingle · Pull Request #182 · jMonkeyEngine/wiki · GitHub that updates the 3.4 to 3.8 references
- I’ve changed $(npm bin) to npx
That last one I want to check with people. I’ve done this because $(npm bin) is linux specific while I believe npx is cross platform compatible. It works on my windows computer, is anyone who has a linux PC able to check it still works for them?
Local build
While doing this I noticed that the local changes seemed to be being ignored. I tracked this down to the wiki-playbook.yml file. It is because of this section
content:
sources:
- url: https://github.com/jMonkeyEngine/wiki.git
branches: [HEAD, v3.3, v3.2]
start_path: docs
- url: https://github.com/jMonkeyEngine/wiki-ui
branches: HEAD
start_path: docs
- url: .
branches: HEAD
start_path: docs-wiki
wiki-ui is a seperate repo so makes sense it is referred to like that, but wiki.git is the current repo
The docs path uses the remote repository, not the local repository. If I change it to . it works fine. docs-wiki is already like that. I can see it was changed from . to https://github.com/jMonkeyEngine/wiki.git back in 2020 in a commit by @mitm . Do you or anyone else know why? Ideally I’d like to change it back to . so local development is easier