Code review for pull request 1758: help please!

sgold · February 2, 2022, 9:27pm

Do you understand how the Engine uses GLSL and J3MD files? If so, then I need someone like you to review this pull request:

github.com/jMonkeyEngine/jmonkeyengine

Add FOR macro to GLSL preprocessor and J3MD

jMonkeyEngine:master ← riccardobl:glslfor

opened 11:12AM - 20 Jan 22 UTC

riccardobl

+228 -4

This can be used in shaders that need to repeat some code where loops cannot be …used (eg. uniforms declaration). See for example https://github.com/jMonkeyEngine/jmonkeyengine/blob/ceb356462aeedf7769dced52e1d5572b01deca31/jme3-terrain/src/main/resources/Common/MatDefs/Terrain/TerrainLighting.frag#L20-L56 This code can be rewritten like so ```java #for i=0..12 (#ifdef DIFFUSEMAP_$i $0 #endif) uniform sampler2D m_DiffuseMap_$1; #endfor ``` *Note: the first diffuse map (m_DiffuseMap) will be renamed in m_DiffuseMap0* As you can see, it makes code much more readable and maintainable.

sgold · February 4, 2022, 7:15am

1758 got integrated. Thank for the help, @pspeed @yaRnMcDonuts @grizeldi @tlf30.