Enable gamma correction by default

sgold · May 11, 2020, 10:47pm

Currently the default for “GammaCorrection” in AppSettings is false:

jMonkeyEngine/jmonkeyengine/blob/f808187142b79fa6c82c38b58ba09b71c90aa2bb/jme3-core/src/main/java/com/jme3/system/AppSettings.java#L287


    defaults.put("Title", JmeVersion.FULL_NAME);
    defaults.put("Renderer", LWJGL_OPENGL2);
    defaults.put("AudioRenderer", LWJGL_OPENAL);
    defaults.put("DisableJoysticks", true);
    defaults.put("UseInput", true);
    defaults.put("VSync", false);
    defaults.put("FrameRate", -1);
    defaults.put("SettingsDialogImage", "/com/jme3/app/Monkey.png");
    defaults.put("MinHeight", 0);
    defaults.put("MinWidth", 0);
    defaults.put("GammaCorrection", false);
    defaults.put("Resizable", false);
    defaults.put("SwapBuffers", true);
    defaults.put("OpenCL", false);
    defaults.put("OpenCLPlatformChooser", DefaultPlatformChooser.class.getName());
    //  defaults.put("Icons", null);
}
/**
 * Create a new instance of <code>AppSettings</code>.
 * <p>

I remember Nehon wanted to change it to true. Perhaps that change should happen in JME 3.4. Any opinions?

danielp · May 11, 2020, 11:01pm

I’d suggest changing it to true - it should always be used, and it’s a subtlety that’s easy to miss.

mitm · May 11, 2020, 11:22pm

He also said it should be removed from SettingsDialog.

pspeed · May 11, 2020, 11:28pm

That part I disagree with.

Apps that are using unshaded or regular lighting and have configured colors specifically will all look broken and washed out. Being able to toggle that check box off to check is a huge advantage to tracking down what the real issue is instead of just assuming 3.4 is broken.

As I recall, even the JME color constants look messed up with gamma=true because there is no easy programmatic way of using setAsSrgb() in a way that is different when gamma is/isn’t enabled.

mitm · May 11, 2020, 11:34pm

There is no way to disable the toggle short of not using the dialog is there?

pspeed · May 11, 2020, 11:37pm

Yeah, just like there is no way to disable AA without not using the dialog, etc…

It’s currently a very basic dialog meant primarily for tests, examples, and prototyping.

…which I guess is ok in the end since it’s one of the half-dozen issues with glfw…

mitm · May 11, 2020, 11:39pm

Right, makes sense.

pspeed · May 11, 2020, 11:40pm

I wish we could get away with enabling vsync by default, too… but I know folks would freak out if suddenly their app is only rendering exactly as many frames as needed instead of 10x more than their display can ever show.

sgold · May 12, 2020, 4:59am

Yeah, I decided not to mention that tiny detail One step at a time!

If there’s no objection by Thursday (to changing the gamma default) I’ll change it in master branch.

sgold · May 12, 2020, 5:09am

There is no way to disable the toggle short of not using the dialog is there?

Yeah, just like there is no way to disable AA without not using the dialog, etc…

It’s possible (in JME 3.3) to enable/disable MSAA/gamma by performing a restart … thanks to @tonihele and his PR 1269.

pspeed · May 12, 2020, 5:10am

Yes, but you can’t remove the toggle (or AA) from the dialog… which is what he was asking about.

sgold · May 12, 2020, 5:16am

Oops! I misread the double negatives.

sgold · May 15, 2020, 9:43pm

That’s done: SHA1 hash 6ade1a0.

When I went to update the javadoc, I found it already claiming that the default setting is “true”. This change resolves that issue

Regarding vsync: I’d support changing that default to “true” as well. And if we’re going to change it, JME 3.4 might be a good time to do so.

pspeed · May 15, 2020, 9:46pm

I’m for it. (obviously)

It’s easy enough to turn off if folks want to hear their GPU scream through their desktop speakers as it blazes 1500 FPS that will never be displayed.

For those who are serious about watching the performance of their frames, the visual profilers are perhaps a better tool anyway. You can see spiky frames and not just some average over time.

sgold · May 16, 2020, 4:11am

You handle more troubleshooting requests than I do. If you’re for it, that counts for a lot. To minimize confusion, I’ll open a new topic for it.

adi.barda · May 19, 2020, 5:10am

I just noticed yesterday that whenever I set setGammaCorrection(true) and then use the water filter (simple water filter - SimpleWaterProcessor) JME is stuck and I need to restart the JVM