Enable VSync by default

sgold · May 16, 2020, 4:21am

Currently the default for “VSync” in AppSettings is false:

jMonkeyEngine/jmonkeyengine/blob/f808187142b79fa6c82c38b58ba09b71c90aa2bb/jme3-core/src/main/java/com/jme3/system/AppSettings.java#L282


defaults.put("Frequency", 60);
defaults.put("DepthBits", 24);
defaults.put("StencilBits", 0);
defaults.put("Samples", 0);
defaults.put("Fullscreen", false);
defaults.put("Title", JmeVersion.FULL_NAME);
defaults.put("Renderer", LWJGL_OPENGL2);
defaults.put("AudioRenderer", LWJGL_OPENAL);
defaults.put("DisableJoysticks", true);
defaults.put("UseInput", true);
defaults.put("VSync", false);
defaults.put("FrameRate", -1);
defaults.put("SettingsDialogImage", "/com/jme3/app/Monkey.png");
defaults.put("MinHeight", 0);
defaults.put("MinWidth", 0);
defaults.put("GammaCorrection", false);
defaults.put("Resizable", false);
defaults.put("SwapBuffers", true);
defaults.put("OpenCL", false);
defaults.put("OpenCLPlatformChooser", DefaultPlatformChooser.class.getName());
//  defaults.put("Icons", null);

As far as I know, the main use of VSync=false is crude performance testing. Most JME applications should enable VSync, but like gamma correction, it’s a detail that’s easily overlooked.

Since we’ve started changing AppSettings defaults, perhaps now (i.e. JMonkeyEngine 3.4) is the time to change the default for VSync to true.

If there are questions or concerns, please speak up!

tlf30 · May 16, 2020, 5:35am

Do it!

tonihele · May 16, 2020, 10:34am

There is another… With GSync/Freesync it is supposed to be off as far as I understand. Just thought I’d mention.

sgold · May 16, 2020, 6:11pm

What’s GSynch/Freesync?

jayfella · May 16, 2020, 6:39pm

Its a technology that syncs the monitor to a fixed frame rate to remove tearing completely without the input lag usually inherited from enabling v-sync.

Gsync is nVidia, FreeSync is ATi.

sgold · May 16, 2020, 9:35pm

What would be required to use Gsync or FreeSync with JMonkeyEngine?

jayfella · May 17, 2020, 7:37am

disable vsync.

I don’t think it requires support from the game. From what I read the monitor adjusts its framerate to match the output using a module on the monitor itself.

sgold · May 17, 2020, 5:47pm

disable vsync.

Easy enough to do. If Gsync or FreeSync becomes the norm, we can easily change our default back to false.

If there’s nothing more to discuss, I’ll go ahead and commit the change.

Edit: That’s done: SHA1 hash=f34e660.