Engine Versions 3.3.x

Darkchaos · April 17, 2020, 1:18am

Then maybe related to the quote below:

 * If the GPU supports OpenGL2 or later, then the OpenGL2.0 renderer will
 * be used, otherwise, the OpenGL1.1 renderer is used.

To enforce OpenGL 2.0?
I guess we will never know what the motivation behind this was, but it prevents the SDK from using the 3.2 Core Profile as it renders in that AWT Panels.

pspeed · April 17, 2020, 1:39am

I guess it’s fine to remove the line.

We try really hard to make it safe to upgrade to point releases because it avoids accidentally teaching folks never to upgrade.

I struggle to imagine a case where this particular fix causes a problem these days, though.

sgold · April 18, 2020, 10:48am

I see that issue 1336: AWTPanels forcing OpenGL 2.0 is still open. What’s needed to resolve that issue?

Darkchaos · April 18, 2020, 12:51pm

I guess now just a commit to remove this line, provided that we will cherry pick it to 3.3

sgold · April 18, 2020, 6:32pm

Okay, I’ll take care of it.

sgold · April 19, 2020, 5:25am

I’m trying to decide whether PR 1342: Fixes #1341: AudioBuffer.updateData only allows direct buffers should be integrated into 3.3.1 . Any opinions?

pspeed · April 19, 2020, 7:49am

I think it’s probably ok. I think the only users that would see an adverse change in behavior (ie: their code stops working when it worked before) are the ones who create their own buffers and then never play the audio. Both seem rare enough on their own, together even rarer.

sgold · April 19, 2020, 6:15pm

I’ve picked many cherries to the v3.3 branch. I’ll begin writing a description for the 3.3.1 release.

I’d appreciate help testing the current release candidate (aka commit a150deb). I will test on Windows and Linux, but I don’t have a macOS or Android setup. Also, extra eyes will improve our odds of noticing any issues.

“@tonihele, have you your axe ready?”

remy_vd · April 19, 2020, 7:21pm

I’ll do some macOS testing tomorrow.

tonihele · April 19, 2020, 8:03pm

I’ll get my small axe tomorrow then. Maybe see that we can still run OpenKeeper and few tests. I don’t have mac nor Android setup either.

sgold · April 19, 2020, 10:15pm

I’ll do some macOS testing tomorrow.

I’ll get my small axe tomorrow then. Maybe see that we can still run OpenKeeper and few tests.

I promise at least 72 hours for testing, and I thank you both in advance for whatever you can accomplish!

Here’s the latest draft of the release description:

A v3.3 patch release with the following changes relative to v3.3.0-stable:

bugfixes in libraries
- Issue 1304, PR 1321, Issue 1340: PBR shader fails to compile
- Issue 1347: ClassCastException in TerrainPath.reIndexGeometry()
- PR 1338: AndroidNativeImageLoader attempts to open stream 2x
- Issue 1341: indirect audio buffer causes OpenAL to crash
- Issue 995: unclosed query in DetailedProfiler
- Issue 1272: renderer mistakenly believes it is on mobile
- Issue 1319: deadlock if context initialization fails
- PR 1322: GL_INVALID_ENUM in debug mode
- Issue 1336: AWTPanels forces OpenGL 2.0
various improvements to tests and examples
various improvements to javadoc and code formatting

sgold · April 21, 2020, 3:30am

So far, my testing has uncovered a few new issues:

I understand 1351 and don’t consider it a showstopper. I need help analyzing 1353 and 1354, however.

remy_vd · April 21, 2020, 8:25am

I’m halfway through the examples.

Issues so far:

Error in TestReleaseDirectMemory · Issue #1355 · jMonkeyEngine/jmonkeyengine · GitHub
PBRLighting shader compilation error on macOS with OpenGL2 - Invalid call of undeclared identifier 'textureCubeLod' · Issue #1356 · jMonkeyEngine/jmonkeyengine · GitHub

I also found the #1354 error in TestAwtPanels.

Other issues where I’m unsure I should create a ticket for:

TestAnimMorphSerialization → throws an com.jme3.asset.AssetNotFoundException: Models/gltf/zophrac/scene.gltf
TestTessellationShader → requires GLSL400 but doesn’t set the Renderer to OpenGL4 (throws error when running by default on OpenGL2)
TestGeometryShader → requires GLSL330 but doesn’t set the Renderer to OpenGL33 (throws error when running by default on OpenGL2)

Darkchaos · April 21, 2020, 11:30am

This is an “issue” with you running mesa drivers on linux, correct?

Default openGL2 is “compat” profile, so usually up to what your GPU Supports, so it is 4.4 for the rest of the world

Ali_RS · April 21, 2020, 11:32am

…

Darkchaos · April 21, 2020, 11:34am

Oh, I am stupid. But the same applies here, on Mac OS we have to setup the core profile otherwise we are in the 2.0 Core Profile.

That being said, I think we can only go to 3.2 or 3.3, so Tessellation won’t work.
It’s a good thing, adding the core profiles to the relevant Tests though, I guess.

remy_vd · April 21, 2020, 11:42am

Indeed, when correctly setting the core profile there is no issue (speaking only for Mac). That’s why I was not sure if I should create an issue for it.
I’m also a fan of setting the correct core profile depending on what you try to test. It makes the test application very clear on the requirements.

sgold · April 21, 2020, 3:41pm

The TestAnimMorphSerialization crash is a known issue, but I can’t look up the number at the moment due to a network or GitHub issue.

Edit: I was thinking of issue 1089, which is slightly different. I assume the TestAnimMorphSerialization is simply a matter of needing to download the model from Sketchfab, but you might as well open a ticket so we can discuss it more easily.

I reverted the fix to issue 1336. We have a new 3.3.1 release candidate: a667f5e

sgold · April 21, 2020, 4:26pm

I’m looking for a PR to configure appropriate core profiles in jme3-examples. Do I have a volunteer?

remy_vd · April 21, 2020, 6:40pm

I’ll do it.

edit: Set the minimum required OpenGL profiles for the geometry and tessellation shader test cases by rvandoosselaer · Pull Request #1358 · jMonkeyEngine/jmonkeyengine · GitHub

Added for the Geometry and Tessellation shader examples. If I come across more examples, I’ll add them too.