Engine Versions 3.3.x

jayfella · April 22, 2020, 9:08am

Just noting here just in case anyone is writing a list of changes. I didn’t submit a PR because they’re so basic there’s no need for discussion.

Added chaining methods for ColorRGBA that returns itself.
- setRed
- setGreen
- setBlue
- setAlpha
Added a static method to create ColorRGBA objects from RGBA255 values.
- ColorRGBA.fromRGBA255(int red, int green, int blue, int alpha);

github.com

jMonkeyEngine/jmonkeyengine/blob/master/jme3-core/src/main/java/com/jme3/math/ColorRGBA.java#L212


        a = rgba.a;
    }
    return this;
}
/**
 * Sets the red color to the specified value.
 * @param value the value to set the red channel.
 * @return the ColorRGBA object with the modified value.
 */
public ColorRGBA setRed(float value) {
    r = value;
    return this;
}
/**
 * Sets the green color to the specified value.
 * @param value the value to set the green channel.
 * @return the ColorRGBA object with the modified value.
 */
public ColorRGBA setGreen(float value) {

github.com

jMonkeyEngine/jmonkeyengine/blob/master/jme3-core/src/main/java/com/jme3/math/ColorRGBA.java#L676


}
/**
 * Converts a color from RGBA 255 values.
 * @param r the red value in 0-255 range.
 * @param g the green value in 0-255 range.
 * @param b the blue value in 0-255 range.
 * @param a the alpha value in 0-255 range.
 * @return the ColorRGBA equivalent of the RGBA 255 color.
 */
public static ColorRGBA fromRGBA255(int r, int g, int b, int a) {
    return new ColorRGBA(r / 255.0F, g / 255.0F, b / 255.0F, a / 255.0F);
}
/**
 * Transform this <code>ColorRGBA</code> to a <code>Vector3f</code> using
 * x = r, y = g, z = b. The Alpha value is not used.
 * This method is useful for shader assignments.
 *
 * @return A <code>Vector3f</code> containing the RGB value of this <code>ColorRGBA</code>.
 */

sgold · April 22, 2020, 9:13am

But the commits you refer to are only in the master branch of the repo, so they won’t affect JME version 3.3.1, which is the topic here.

pspeed · April 22, 2020, 9:14am

And they are new features and so wouldn’t be a candidate for 3.3.1.

jayfella · April 22, 2020, 9:21am

Sorry. I don’t know what I’m doing today.

sgold · April 22, 2020, 9:31am

And still we love and respect you.

sgold · April 22, 2020, 6:28pm

PR 1358 is now integrated into the master branch and cherrypicked into the v3.3 branch. So we have a new release candidate: 4b62b70

sgold · April 24, 2020, 6:51pm

I decided to include a fix for issue 1360. The latest release candidate is 618e890.

Unless there’s a serious issue with 618e890, I plan to release 3.3.1 about 24 hours from now.

sgold · April 25, 2020, 7:10pm

Hm. I pushed a tag for “v3.3.1-stable”. I expected GitHub to build the release automatically, but I don’t see any evidence of that happening.

Any advice?

tlf30 · April 25, 2020, 7:39pm

I do not know what the problem is, but I noticed two days ago that it does not look like there are snapshots in jitpack anymore. My projects that use the snapshots will no longer build, and I do not see them listed in jitpack.

EDIT: I should clarify, there are no more 3.3.x snapshots.
EDIT 2: Actually, I think I found it, but it is missing the version number now…?
https://jitpack.io/#jMonkeyEngine/jmonkeyengine/-SNAPSHOT

sgold · April 25, 2020, 7:51pm

I wonder if it’s because the “v3.3” branch isn’t listed in .github/workflows/main.yml
But in that case, how did the v3.3.0-stable release happen? @pspeed ?

pspeed · April 25, 2020, 7:53pm

I pushed the tag and magic happened. I don’t understand the magic… I just invoke it.

…when it doesn’t work, I don’t really know why.

sgold · April 25, 2020, 8:32pm

Thanks, Paul. It’s good to know the “magic” worked for you as recently as 30 March.

Before I delete the tag and experiment, I’d like to hear from @riccardoBlb , since he did most of the work to set up GitHub Actions.

mitm · April 25, 2020, 10:05pm

Not according to travis.
https://travis-ci.org/github/jMonkeyEngine?page=1&tab=repositories&timeInterval=month

sgold · April 25, 2020, 10:17pm

The Engine hasn’t used Travis since October. That’s when Riccardo moved it over to GitHub Actions.

mitm · April 25, 2020, 10:40pm

I see, do they have something like the link to examine builds?

sgold · April 25, 2020, 10:44pm

Here’s the link: Actions · jMonkeyEngine/jmonkeyengine · GitHub

mitm · April 25, 2020, 10:46pm

Thanks, that looks way more useful than travis.

sgold · April 26, 2020, 12:07am

I’ve reconfigured the workflow and deleted the tag. I’ll retry with a new tag.

Edit: that didn’t work either. GitHub ran the workflow for the commit, then ignored the pushed tag.

I’m brainstorming:

Because GitHub remembers that I recently pushed a tag with the same name?
Because the pushed tag arrived too long after the commit?
Some other reason??

RiccardoBlb · April 26, 2020, 7:08am

It doesn’t automatically build all tags as releases. To create a new release you need to use the github ui.

(it can use an existing tag, or create a new one)

sgold · April 26, 2020, 2:55pm

@RiccardoBlb: Hm. Usually I wait to “draft” the release at GitHub until after all the the JARs and other Maven artifacts have been deployed to BinTray/JCenter. Each time I pushed a tag to GitHub, I expected the DeployRelease job to run, but it didn’t.

When should I expect the DeployRelease job to run?