FlyByCamera#registerWithInput visible cursor when disabled

Nakano · March 15, 2023, 1:18pm

I saw, FlyByCamera#registerWithInput visible the Cursor on InputManager, if the FlyByCamera is disabled.
Make this sense? I think, when the FlyByCamera is disabled, it should not affect the application and may change a previous set value, shouldn’t it?
Also, registerWithInput is called in FlyCamAppState#initialize, hence it is called after simpleInitApp. I think, it is unnatural and unexpected to set the cursor automatic visible, if the user set them in simpleInitApp invisible.

github.com

jMonkeyEngine/jmonkeyengine/blob/ac8c1012d2ded0812d91a393f935c9f0f7d0c192/jme3-core/src/main/java/com/jme3/input/FlyByCamera.java#L283


      
          

              // keyboard only WASD for movement and WZ for rise/lower height

              inputManager.addMapping(CameraInput.FLYCAM_STRAFELEFT, new KeyTrigger(KeyInput.KEY_A));

              inputManager.addMapping(CameraInput.FLYCAM_STRAFERIGHT, new KeyTrigger(KeyInput.KEY_D));

              inputManager.addMapping(CameraInput.FLYCAM_FORWARD, new KeyTrigger(KeyInput.KEY_W));

              inputManager.addMapping(CameraInput.FLYCAM_BACKWARD, new KeyTrigger(KeyInput.KEY_S));

              inputManager.addMapping(CameraInput.FLYCAM_RISE, new KeyTrigger(KeyInput.KEY_Q));

              inputManager.addMapping(CameraInput.FLYCAM_LOWER, new KeyTrigger(KeyInput.KEY_Z));

          

              inputManager.addListener(this, mappings);

              inputManager.setCursorVisible(dragToRotate || !isEnabled());

          

              Joystick[] joysticks = inputManager.getJoysticks();

              if (joysticks != null && joysticks.length > 0){

                  for (Joystick j : joysticks) {

                      mapJoystick(j);

                  }

              }

          }

          

          protected void mapJoystick(Joystick joystick) {

Disable sets the cursor already visible, depending on other settings, may enabling could set it also?

github.com

jMonkeyEngine/jmonkeyengine/blob/ac8c1012d2ded0812d91a393f935c9f0f7d0c192/jme3-core/src/main/java/com/jme3/input/FlyByCamera.java#L202


      
          

          /**

           * Enable or disable this controller. When disabled, the controller ignored

           * input.

           *

           * @param enable true to enable, false to disable

           */

          public void setEnabled(boolean enable){

              if (enabled && !enable){

                  if (inputManager!= null && (!dragToRotate || (dragToRotate && canRotate))){

                      inputManager.setCursorVisible(true);

                  }

              }

              enabled = enable;

          }

          

          /**

           * Test whether this controller is enabled.

           *

           * @return true if enabled, otherwise false

           * @see #setEnabled(boolean)

Edit: Fixed a mistake.