GlowColor unused if a GlowMap is specified

Ali_RS · December 13, 2020, 10:31am

Ok, looking into glow frag shader seems glow color is not considered when a glow map is specified.

jMonkeyEngine/jmonkeyengine/blob/69caa65fda034f43f4256676b194071e1a8a38e6/jme3-core/src/main/resources/Common/MatDefs/Light/Glow.frag#L18-L32


      
          void main(){

              #ifdef HAS_GLOWMAP

                  #if defined(NEED_TEXCOORD1) 

                     gl_FragColor = texture2D(m_GlowMap, texCoord1);

                  #else 

                     gl_FragColor = texture2D(m_GlowMap, texCoord);

                  #endif

              #else

                  #ifdef HAS_GLOWCOLOR

                      gl_FragColor =  m_GlowColor;

                  #else

                      gl_FragColor = vec4(0.0);

                  #endif

              #endif

          }

Also found a relevant topic

Can we add the above changes to Glow.frag proposed by @abies?

Edit:

Went ahead and submitted a PR