Next Engine release

Ali_RS · January 15, 2023, 6:06pm

They are now released into maven central, it might take a few hours to show up on Maven Central Repository Search.

@Pesegato, please try the new release and let me know if you had an issue.

xuan · January 15, 2023, 7:27pm

I found an issue with the ScreenshotAppState. Taking one screenshot works but the second time it crashes the app with:

com.jme3.renderer.RendererException: Attempting to upload empty buffer (remaining = 0), that's an error
	at com.jme3.renderer.lwjgl.LwjglRender.checkLimit(LwjglRender.java:22)
	at com.jme3.renderer.lwjgl.LwjglGL.glReadPixels(LwjglGL.java:399)
	at com.jme3.renderer.opengl.GLRenderer.readFrameBufferWithGLFormat(GLRenderer.java:2165)
	at com.jme3.renderer.opengl.GLRenderer.readFrameBuffer(GLRenderer.java:2147)
	at com.jme3.app.state.ScreenshotAppState.postFrame(ScreenshotAppState.java:287)
	at com.jme3.renderer.RenderManager.renderViewPort(RenderManager.java:1233)
	at com.jme3.renderer.RenderManager.render(RenderManager.java:1297)
	at com.jme3.app.SimpleApplication.update(SimpleApplication.java:278)
	at com.jme3.system.lwjgl.LwjglWindow.runLoop(LwjglWindow.java:622)
	at com.jme3.system.lwjgl.LwjglWindow.run(LwjglWindow.java:711)
	at java.lang.Thread.run(Thread.java:748)

The code to reproduce is as simple as:

public class ScreenshotDemo extends SimpleApplication {

  public static void main(String[] args) {
    new ScreenshotDemo().start();
  }

  public ScreenshotDemo() {
    super(new ScreenshotAppState(null, "test-"));
  }

  @Override
  public void simpleInitApp() {
    inputManager.addMapping("ScreenShot", new KeyTrigger(KeyInput.KEY_F12));
  }

}

xuan · January 15, 2023, 7:52pm

I bisected the issue to this commit: Fix issue #1850 (JmeSystem.writeImageFile() throw java.nio.BufferUnde… · jMonkeyEngine/jmonkeyengine@49a3102 · GitHub

Ali_RS · January 15, 2023, 8:23pm

@xuan thanks for testing and reporting this issue

Using imageData.duplicate() in the below line fixed the issue for me. Going to submit a patch.

github.com

jMonkeyEngine/jmonkeyengine/blob/6d83c63e5f864a61e3c10aeec449c41420765db9/jme3-desktop/src/main/java/com/jme3/system/JmeDesktopSystem.java#L103


      
              int h = original.getHeight();
              int[] pixels = new int[w * h];
              original.getRGB(0, 0, w, h, pixels, 0, w);
              BufferedImage opaqueImage = new BufferedImage(w, h, BufferedImage.TYPE_INT_RGB);
              opaqueImage.setRGB(0, 0, w, h, pixels, 0, w);
              return opaqueImage;
          }
          
          
@Override
          public void writeImageFile(OutputStream outStream, String format, ByteBuffer imageData, int width, int height) throws IOException {
              BufferedImage awtImage = ImageToAwt.convert(new Image(Image.Format.RGBA8, width, height, imageData, ColorSpace.Linear), false, true, 0);
              awtImage = verticalFlip(awtImage);
          
          
    ImageWriter writer = ImageIO.getImageWritersByFormatName(format).next();
              ImageWriteParam writeParam = writer.getDefaultWriteParam();
          
          
    if (format.equals("jpg")) {
                  awtImage = ensureOpaque(awtImage);
          
          
        JPEGImageWriteParam jpegParam = (JPEGImageWriteParam) writeParam;
                  jpegParam.setCompressionMode(ImageWriteParam.MODE_EXPLICIT);

Edit:

Calling imageData.clear(); after the above line also does fix it.

Should I go with the first solution or the second one?

Ali_RS · January 15, 2023, 9:13pm

Submitted a fix

xuan · January 15, 2023, 10:42pm

Great job! Thanks

Pesegato · January 16, 2023, 10:05am

Yes it works now!

Ali_RS · January 19, 2023, 9:07am

I hope to release the first beta on 24 January and freeze the code for new features on v3.6 branch.

Ali_RS · January 24, 2023, 9:32am

JME 3.6.0-beta1 is released and is available in the maven central repository. Please try it out and report it if you found an issue.

The master branch is updated to version 3.7 for continuous development.

fba · January 24, 2023, 2:47pm

WARNING: JmeDialogsFactory implementation not found.

Not sure what that means, but we don’t have a settings dialog anymore?
For the record, I didn’t test the alphas. Jumped from 3.5.2-stable straight into this beta.

Ali_RS · January 24, 2023, 3:02pm

We do have it, but it is now in a separate module jme3-awt-dialogs.

You can enable it by adding this dependency:

implementation "org.jmonkeyengine:jme3-awt-dialogs:$jmeVersion"

fba · January 24, 2023, 3:05pm

Nice move. Thanks!

capdevon · January 25, 2023, 6:28pm

github.com/jMonkeyEngine/jmonkeyengine

App crashes with setUseJoysticks=true on lwjgl2 and windows 11

opened 06:27PM - 25 Jan 23 UTC

capdevon

The app crashes with setUseJoysticks=true on lwjgl2 and Windows 11, both with th…e joystick connected and disconnected. Details: * windowds-11 * jdk-11 * jme-3.6.0-beta1. * lwjgl2 ```java public class Main extends SimpleApplication { /** * Start the jMonkeyEngine application * @param args */ public static void main(String[] args) { Main app = new Main(); AppSettings settings = new AppSettings(true); settings.setUseJoysticks(true); //I have not connected the joystick. settings.setResolution(1280, 720); app.setSettings(settings); app.setShowSettings(true); app.setPauseOnLostFocus(false); app.start(); } ... } ``` ``` gen 25, 2023 5:08:32 PM com.jme3.system.JmeDesktopSystem initialize INFO: Running on jMonkeyEngine 3.6.0-beta1 * Branch: HEAD * Git Hash: ee91fb8 * Build Date: 2023-01-24 gen 25, 2023 5:08:32 PM com.jme3.system.lwjgl.LwjglContext printContextInitInfo INFO: LWJGL 2.9.5 context running on thread jME3 Main * Graphics Adapter: igdumdim64 * Driver Version: null * Scaling Factor: 1 WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by com.jme3.util.ReflectionAllocator (file:/C:/Users/xxxx/.gradle/caches/modules-2/files-2.1/org.jmonkeyengine/jme3-core/3.6.0-beta1/f3f826a70693ae115c1e84a0ddd8ca971f61a4bb/jme3-core-3.6.0-beta1.jar) to method sun.nio.ch.DirectBuffer.cleaner() WARNING: Please consider reporting this to the maintainers of com.jme3.util.ReflectionAllocator WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release gen 25, 2023 5:08:32 PM com.jme3.renderer.opengl.GLRenderer loadCapabilitiesCommon INFO: OpenGL Renderer Information * Vendor: Intel * Renderer: Intel(R) Iris(R) Xe Graphics * OpenGL Version: 3.2.0 - Build 31.0.101.3358 * GLSL Version: 1.50 - Build 31.0.101.3358 * Profile: Core gen 25, 2023 5:08:32 PM com.jme3.renderer.opengl.GLRenderer setMainFrameBufferSrgb WARNING: Driver claims that default framebuffer is not sRGB capable. Enabling anyway. ``` ![crash](https://user-images.githubusercontent.com/32201701/214643875-fae9425a-1f5f-4188-9ae8-b1d534a2c4e6.png)