The Contribution Mega-Thread

[sgold]

PR 1493, PR 1494 and PR 1495 were recently opened for review.

[sgold]

PR 1498 and PR 1500 were recently submitted. They are both ready for review.

[sgold]

Three more pull requests ready for review:

• PR 1501 - jme3-examples: convert fields to local variables
• PR 1502 - cleanup of scene processors that don’t implement profiling
• PR 1503 - convert TestAttachmentsNode to the new animation system

[Ali_RS]

Another PR ready for review:

• PR 1505

Also, an issue to be discussed:

• Issue 1497

[sgold]

PR 1507 - AnimationFactory should support the new system is ready for code review.

Unless there is substantive discussion, I plan to integrate the following 6 pull requests in 24 hours:

• PR 1498 - visible methods and fields shouldn’t depend on invisible classes
• PR 1500 - convert TestWalkingChar to the new animation system
• PR 1501 - jme3-examples: convert fields to local variables
• PR 1502 - cleanup of scene processors that don’t implement profiling
• PR 1503 - convert TestAttachmentsNode to the new animation system
• PR 1504 - more constructors and methods for ArmatureMask

[sgold]

Spring cleaning is in full swing. Three more pull requests are ready for review:

• PR 1508 - add a CinematicEvent for the new animation system
• PR 1509 - avoid accessing static fields through instance variables
• PR 1510 - delete deprecated setters that are currently no-ops

[sgold]

Ready for review:

• PR 1512 - PreNormalPass fix for Unshaded and PBRLighting

[sgold]

Ready for code review:

• PR 1513 - Fixed for windows and linux hack for mac threading
• PR 1515 - resolve issue #1452 (convert jme3-examples to new system)

[Ali_RS]

Another PR ready for review:

• PR 1517 - FXAA.frag: read alpha value from texture instead of passing constant 1.

[sgold]

Also ready for review:

• PR 1478 - add PBR shaders for terrain
• PR 1511 - add package summaries
• PR 1516 - privatize package-private loggers

[sgold]

PR 1519 - resolve javadoc warnings in jme3-effects is ready for review.

[sgold]

New Engine issues for discussion:

• PR 1514 - jme-lwjgl3 - bug for starting app
• PR 1520 - remove com.jme3.anim.Weights from jme3-core

[sgold]

Also ready for review:

• PR 1521 - add missing javadoc to the com.jme3.anim package
• PR 1522 - resolve javadoc warnings in jme3-jbullet

[sgold]

A pull request needs review:

• PR 1526 - refactor context restart

number of open issues against the Engine = 152

[sgold]

There’s a recently-opened issue:

• issue 1528 - missing support for MacOSX_ARM64

and 3 PRs recently submitted for review:

• PR 128 - Engine Release Guide
• PR 130 - copyedits
• PR 1527 - GLRenderer: avoid NPE reported by Pavl_G

[sgold]

Another new issue:

• issue 1529 - more constructors for AnimEvent

and another new PR to review:

• PR 1530 - distinguish ARM Macs from X86/PPC Macs

[sgold]

New issue: issue 1533 - AssertionError while running TestAnimMigration

New PRs to review:

• PR 1531 - TransformTrack: protect the no-arg constructor
• PR 1532 - TransformTrack: add null checks
• PR 1534 - fix failed assertion in TestAnimMigration
• PR 17 - start.md: fetch JME libraries from Maven Central

[sgold]

New PR: PR 1536 - Joint: make 2 methods accessible to subclasses.

[sgold]

New PR: PR 1537 - AnimEvent: solve bug where onStop() kills prior event on the same layer.