The Contribution Mega-Thread

An opinion to provide a discussion for, which is modifying android build script to a dynamic android build script based on the SDK.Dir & ndk.Dir specified from local.properties :

Edit : check the last comment & the 2 previous ones…

Ali_RS · October 17, 2021, 7:37am

New issue (easy first fix!)

Pavl_G · October 23, 2021, 5:47am

I have changed it, but if i do a PR that would redirect commits towards the docs PR…that would obviously disrupt everything

Ali_RS · October 23, 2021, 5:53am

Thanks for working on that. You should make a new branch and commit the changes to that so it won’t disrupt your previous PR (animation JavaDoc).

Pavl_G · October 23, 2021, 5:55am

Its already in a new branch, even i made a new organization w/ a new fork, but it actually redirects me to the same PR, i think i should make a new github acc

EDIT : Branch name : Scrappers-glitch:BinEnhancement

@Ali_RS I have understood now why did that happen, that’s because I have first committed to my master fork, then I did the new Branch (BinEnhancement) which is now (new+master), the right order should be creating the branch then doing a PR from that branch(w/o merging into the master fork directly).

Pavl_G · October 23, 2021, 7:05am

Alright i did the PR from other organization through git directly

Ali_RS · October 23, 2021, 8:11am

Thanks @Pavl_G