April 26, 2019, 3:02pm
OK, I thought I would ask as a way to clarify because I have become very confused, but this is my understanding:
Old animation system: The one currently documented in the wiki
MonkAnim: Not in existence anymore / never implemented?
New animation system: In the code, but not in the wiki?
And the new animation system is where
DynamicAnimControl comes from.
Is that all correct?
April 26, 2019, 3:41pm
I think DynamicAnimControl is sgold’s thing and based on the older animation system.
The new animation system was the product of the monkanim development and ticks a lot of those boxes but yeah, in my opinion, is not “monkanim” in the original concept.
com.jme3.anim is the new animation stuff.
jmonkeyengine/jme3-core/src/main/java/com/jme3/anim at master · jMonkeyEngine/jmonkeyengine · GitHub
com.jme3.animation is the old animation stuff. jmonkeyengine/jme3-core/src/main/java/com/jme3/animation at master · jMonkeyEngine/jmonkeyengine · GitHub
April 26, 2019, 3:57pm
I’m uncertain precisely what MonkAnim is and how it relates to the new (JME 3.3) animation system, so I’ve stopped using the term “MonkAnim”.
DynamicAnimControl is a scene-graph
Control that integrates skeleton animation with Bullet physics. It’s been used to animate ropes and ragdolls and implement inverse kinematics.
There are 2 implementations of
the one in the unofficial
Minie library, which works only with the old (pre-3.3) animation system
the one in the
master branch of the JME repo, which works only with the new (3.3) animation system and lacks some of the features found in the
Once JME 3.3 is in beta, I’ll begin transitioning
Minie to JME 3.3, so that the
Minie implementation will work with the new animation system.
April 26, 2019, 4:21pm
Maybe we should name the new animation system “TweenAnim”
April 26, 2019, 4:23pm
Except eventually the new animation system should just be “the animation system” and it will be weird if it has a separate name.
April 26, 2019, 9:40pm
Well unfortunately, everyone can take a dump into the repo without documenting the changes or updating the wiki.
Even though it specifically stated they must do so…
This file has been truncated.
# How to contribute to jMonkeyEngine
First and foremost, you have to familiarize yourself with Git & GitHub. Dig through
[help.github.com](https://help.github.com/), [try.github.io](http://try.github.io/) and the [gh cheat sheet](https://github.com/tiimgreen/github-cheat-sheet/blob/master/README.md) if these are new topics for you. If you'd like to contribute with something other than code, just tell us about it on the forum.
Communication always comes first. **All** code changes and other contributions should start with the [forum](http://hub.jmonkeyengine.org/). Make a thread to explain your change and show us the important bits of your code. If the code is too long to be posted within the forum’s code tags, please paste your code in a Gist or pastebin and link to the submission in your thread. You are required to register on our website in order to create threads. (We do support login via GitHub though).
### New Contributors
Check out the [Projects](https://github.com/jMonkeyEngine/jmonkeyengine/projects/1) tab, where the team has prioritized issues that you as a new contributor can undertake that will familiarize you to the workflow of contributing. This highlights some issues the team thinks would be a good start for new contributors but you are free to contribute on any other issues or integration you wish.
When you're ready to submit your code, just make a [pull request](https://help.github.com/articles/using-pull-requests).
- Do not commit your code until you have received proper feedback.
- In your commit log message, please refer back to the originating forum thread (example) for a ‘full circle’ reference. Also please [reference related issues](https://help.github.com/articles/closing-issues-via-commit-messages) by typing the issue hashtag.
- When committing, always be sure to run an update before you commit. If there is a conflict between the latest revision and your patch after the update, then it is your responsibility to track down the update that caused the conflict and determine the issue (and fix it). In the case where the breaking commit has no thread linked (and one cannot be found in the forum), then the contributor should contact an administrator and wait for feedback before committing.
- If your code is committed and it introduces new functionality, please edit the wiki accordingly. We can easily roll back to previous revisions, so just do your best; point us to it and we’ll see if it sticks!
If your code is committed and it introduces new functionality, please edit the wiki accordingly. We can easily roll back to previous revisions, so just do your best; point us to it and we’ll see if it sticks!
April 27, 2019, 1:45am
I’ll appreciate any constructive feedback on the documentation.
just note for someone who search example:
im gonna try new animation system now myself.